issue/2847 Improved notify subview handling#2848
Merged
Merged
Conversation
oliverfoster
requested review from
cahirodoherty-learningpool,
guywillis,
moloko and
tomgreenfield
July 29, 2020 09:40
cahirodoherty-learningpool
approved these changes
Jul 30, 2020
cahirodoherty-learningpool
left a comment
Contributor
There was a problem hiding this comment.
code 👀
Contributor
There was a problem hiding this comment.
@oliverfoster I haven't accessibility tested this yet as I'm not able to render the popup content in Chrome (running latest v). You can see from the screenshot that an empty Notify renders. I've tested in Firefox and not getting any issues.
I can see from your demo above you were also running Chrome. I'm on a Mac.
UPDATE: Caching issue.
kirsty-hames
approved these changes
Jul 31, 2020
kirsty-hames
left a comment
Contributor
There was a problem hiding this comment.
+1 Tested in latest Chrome, Firefox, Safari, iPhone iOS 13.5.1, iPad iOS 10.3.4.
Accessibility tested in IE11 running Jaws 18 (in particular Hotgraphic / MCQ where you have stacked Notifies).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

#2847
Added
_idas a subviewAdapt.notify.stackfor a list of open popupsFixed
Changed
Adapt.log.deprecatedinstead of a notify specific oneTest
This should be accessibility tested. The feedback notify in the mcq should appear over the mcq notify and be completely keyboard navigable.
To show an mcq:
To show a media component:
To show a text and graphic block:
To remove the close button and have a continue instead: