Update: Updated focus to focus-visible (fixes #231) #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guywillis
requested review from
cahirodoherty-learningpool,
eleanor-heath,
joe-allen-89 and
kirsty-hames
joe-allen-89
reviewed
Dec 5, 2022
Contributor
joe-allen-89
left a comment
joe-allen-89
left a comment
There was a problem hiding this comment.
There's another :focus in accessibility.less which may also need changing.
Contributor
@joe-allen-89 This is a global override for ALL :focus pseudo elements so should remain as is. |
StuartNicholls
approved these changes
Dec 5, 2022
oliverfoster
approved these changes
Dec 6, 2022
|
🎉 This PR is included in version 6.24.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #231
Update
:focusto:focus-visible