Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the order of wrappers in env create function #128

Merged
merged 2 commits into from
Nov 30, 2022

Conversation

felixchalumeau
Copy link
Collaborator

Necessary to make sure that the state descriptors are also updated when using a fixed initial state with the wrapper

maxencefaldor and others added 2 commits November 30, 2022 13:25
@felixchalumeau felixchalumeau marked this pull request as ready for review November 30, 2022 11:42
@codecov-commenter
Copy link

Codecov Report

Merging #128 (e81f13f) into develop (f84f887) will not change coverage.
The diff coverage is 66.66%.

❗ Current head e81f13f differs from pull request most recent head ec6a7d2. Consider uploading reports for the commit ec6a7d2 to get more accurate results

@@           Coverage Diff            @@
##           develop     #128   +/-   ##
========================================
  Coverage    92.31%   92.31%           
========================================
  Files          103      103           
  Lines         5816     5816           
========================================
  Hits          5369     5369           
  Misses         447      447           
Impacted Files Coverage Δ
qdax/environments/__init__.py 89.79% <66.66%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@felixchalumeau felixchalumeau merged commit cfaf3c8 into develop Nov 30, 2022
@limbryan limbryan deleted the fix/fixed-init-state-desc branch November 30, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants