Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: extra-scores for repertoire addition #118

Merged
merged 5 commits into from
Nov 29, 2022

Conversation

manon-but-yes
Copy link
Collaborator

This PR re-open #30 from local branch.

It allows to consider the extra-scores for addition to the container to make the MapElitesRepertoire API more general.

Important note - API modification
The add() method of the repertoire is now taking the batch_of_extra_scores as input, even if the default MapElitesRepertoire is not using it.

@codecov-commenter
Copy link

Codecov Report

Merging #118 (3c8285e) into develop (a5c19a2) will increase coverage by 0.56%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #118      +/-   ##
===========================================
+ Coverage    91.74%   92.30%   +0.56%     
===========================================
  Files           97      103       +6     
  Lines         5403     5810     +407     
===========================================
+ Hits          4957     5363     +406     
- Misses         446      447       +1     
Impacted Files Coverage Δ
qdax/core/emitters/omg_mega_emitter.py 97.95% <ø> (ø)
qdax/core/mome.py 100.00% <ø> (ø)
qdax/core/containers/mapelites_repertoire.py 84.78% <100.00%> (ø)
qdax/core/containers/mome_repertoire.py 98.11% <100.00%> (ø)
qdax/core/map_elites.py 100.00% <100.00%> (ø)
..._test/containers_test/mapelites_repertoire_test.py 100.00% <100.00%> (ø)
qdax/core/containers/archive.py 97.36% <0.00%> (ø)
tests/core_test/containers_test/archive_test.py 100.00% <0.00%> (ø)
qdax/core/emitters/qdpg_emitter.py 100.00% <0.00%> (ø)
qdax/core/emitters/dpg_emitter.py 100.00% <0.00%> (ø)
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@felixchalumeau felixchalumeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me!

@manon-but-yes manon-but-yes merged commit f5b5d94 into develop Nov 29, 2022
@limbryan limbryan deleted the feat/addition-extra-scores branch November 30, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants