Skip to content

Commit 54caf4d

Browse files
mengelbartSean-Der
authored andcommitted
Unbinding should happen on remote stream
The interceptor embeds the NoOp interceptor, so this is not a breaking change. UnbindLocalStream will no longer remove any state. Only when UnbindRemoteStream is called will the state be removed.
1 parent 535d066 commit 54caf4d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pkg/nack/generator_interceptor.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,8 @@ func (n *GeneratorInterceptor) BindRemoteStream(info *interceptor.StreamInfo, re
108108
})
109109
}
110110

111-
// UnbindLocalStream is called when the Stream is removed. It can be used to clean up any data related to that track.
112-
func (n *GeneratorInterceptor) UnbindLocalStream(info *interceptor.StreamInfo) {
111+
// UnbindRemoteStream is called when the Stream is removed. It can be used to clean up any data related to that track.
112+
func (n *GeneratorInterceptor) UnbindRemoteStream(info *interceptor.StreamInfo) {
113113
n.receiveLogsMu.Lock()
114114
delete(n.receiveLogs, info.SSRC)
115115
n.receiveLogsMu.Unlock()

0 commit comments

Comments
 (0)