Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piece Notation #1

Open
adampre opened this issue Dec 21, 2022 · 1 comment
Open

Piece Notation #1

adampre opened this issue Dec 21, 2022 · 1 comment

Comments

@adampre
Copy link
Owner

adampre commented Dec 21, 2022

Still implementing full Algebraic Chess Notation.

@Priyeshpandey
Copy link

A very well thought out design, clean approach. One thing I'd like to suggest, I see a lot of If else statements, and very large functions, you can possibly break common patterns into utils and reduce size of your functions, also you can use switch case instead of if else, that way code is more readable and clean. For Pieces, one idea is to separately init black and white pieces as a hashmap, basically two hashmaps, that way it is easier to track those pieces and reference them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants