Correct glob matching for ** patterns (#166)

Fixes #91. Supercedes #92 and #134.

---------

Co-authored-by: Stephen Mitchell <scum@mac.com>

Author: adamchainz

CHANGELOG.rst

@@ -7,6 +7,15 @@ Unreleased
 
 * Support Python 3.14.
 
+* Correct glob matching to be equivalent to Django’s ``StatReloader`` for ``**`` patterns.
+  This fix is limited to Python 3.13+ because it depends the new |Path.full_match()|__ method.
+
+  .. |Path.full_match()| replace:: ``Path.full_match()``
+  __: https://docs.python.org/3/library/pathlib.html#pathlib.PurePath.full_match
+
+  `PR #166 <https://github.com/adamchainz/django-watchfiles/pull/166>`__.
+  Thanks to Evgeny Arshinov for the report in `Issue #91 <https://github.com/adamchainz/django-watchfiles/issues/91>`__, and Stephen Mitchell for an initial pull request in `PR #134 <https://github.com/adamchainz/django-watchfiles/pull/134>`__.
+
 1.1.0 (2025-02-06)
 ------------------
 

src/django_watchfiles/__init__.py

@@ -1,14 +1,25 @@
 from __future__ import annotations
 
+import sys
 import threading
 from collections.abc import Generator, Iterable
-from fnmatch import fnmatch
 from pathlib import Path
 from typing import Callable
 
 from django.utils import autoreload
 from watchfiles import Change, watch
 
+if sys.version_info >= (3, 13):
+    path_full_match = Path.full_match
+else:
+    # True backport turned out to be too hard. Instead, fall back to the
+    # pre-existing incorrect fnmatch implementation
+
+    from fnmatch import fnmatch
+
+    def path_full_match(path: Path, pattern: str) -> bool:
+        return fnmatch(str(path), pattern)
+
 
 class MutableWatcher:
     """
@@ -67,10 +78,8 @@ def file_filter(self, change: Change, filename: str) -> bool:
             except ValueError:
                 pass
             else:
-                relative_path_str = str(relative_path)
-                for glob in globs:
-                    if fnmatch(relative_path_str, glob):
-                        return True
+                if any(path_full_match(relative_path, glob) for glob in globs):
+                    return True
         return False
 
     def watched_roots(self, watched_files: Iterable[Path]) -> frozenset[Path]:

tests/test_django_watchfiles.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import sys
 import tempfile
 import time
 from pathlib import Path
@@ -119,6 +120,19 @@ def test_file_filter_glob_matched(self):
 
         assert result is True
 
+    @pytest.mark.skipif(
+        sys.version_info < (3, 13),
+        reason="Path.full_match not available before Python 3.13",
+    )
+    def test_file_filter_recursive_glob_matched(self):
+        self.reloader.watch_dir(self.temp_path, "**/*.txt")
+
+        result = self.reloader.file_filter(
+            Change.modified, str(self.temp_path / "test.txt")
+        )
+
+        assert result is True
+
     def test_file_filter_glob_multiple_globs_unmatched(self):
         self.reloader.watch_dir(self.temp_path, "*.css")
         self.reloader.watch_dir(self.temp_path, "*.html")