Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress warning about circuitpython_typing #141

Closed
dhalbert opened this issue Feb 18, 2022 · 3 comments · Fixed by #142
Closed

Suppress warning about circuitpython_typing #141

dhalbert opened this issue Feb 18, 2022 · 3 comments · Fixed by #142

Comments

@dhalbert
Copy link
Contributor

Now that `circuitpython_typing is a separate library, but is not in the bundle (because it's typing definitions only), we are seeing a warning:

$ circup install adafruit_bus_device
Found device at /media/halbert/CIRCUITPY, running CircuitPython 7.2.0-alpha.1-276-g8d4333203.
Searching for dependencies for: ['adafruit_bus_device']
WARNING:
	adafruit_typing is not a known CircuitPython library.
Ready to install: ['adafruit_bus_device']

Suppress this warning.

@askpatrickw
Copy link
Contributor

I think the fix is to add adafruit_typing to the list of libraries not intended to be installed on a board.

https://github.com/adafruit/circup/blob/main/circup/__init__.py#L49

@dhalbert
Copy link
Contributor Author

I hoped there was such a list - thanks for pointing it out. That's an easy PR.

@dhalbert
Copy link
Contributor Author

dhalbert commented Feb 18, 2022

The other bug here is that it's not adafruit_typing, it's circuitpython_typing, and the pypi name is adafruit-circuitpython-typing. I'll fix the appropriate libraries.

No, it's not the libraries: it's because adafruit-circuitpython-typing gets canonically transformed to adafruit_typing for lookup and reporting purposes. But there's another exception list, not_standard_names, that we can use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants