ShiftRegisterKeys key_count value was wrong #9719
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
keypad.ShiftRegisterKeys(..., key_count=some_integer, ...)
had an integer argument, the argument was not correctly converted to an integer. This error was inadvertently introduced by #8143.Testing:
The bug is that
.u_int
was used instead of.u_obj
. When the bug is present,keys.key_count
produces17
(which is the encoded micropython representation of8
). This fix returns8
correctly.