Turn on f-strings for all builds in 7.3.0 #6415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
force-pushed
the
7.3.x-fstrings-for-all
branch
from
fe78d5e to
338e14d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 8.0.0, we are gaining space, at least initially, which is espeically noticeable on small builds. How do we spend it? I was originally going to put back
onewireio, but I'm thinking that making f-strings uniformly available is quite advantageous, because it simplifies writing many examples and libraries.We could do that in 8.0.0, but would it be possible in 7.3.0? I think the sooner, the better. This PR, starting as draft, tests which builds will fail. In 8.0.0, f-strings takes only 440 bytes more in a Trinket M0 build.