added board configuration for Sparkfun ThingPlus RP2040

[mintakka]

Added board configuration files for the Sparkfun ThingPlus RP2040

Builtin NeoPixel, LED, QWIIC port and build-in micro-SD slot all tested and working with the updated pin definitions.

[falkenad]

@mintakka Shouldn't the flash size be 16 as they're 25Q128 flash chips?
IE: #define TOTAL_FLASH_SIZE 8 * 1024 * 1024
Should be:
#define TOTAL_FLASH_SIZE 16 * 1024 * 1024 ?

[mintakka]

Yes it should be, I missed that!

…

On Mon, Mar 15, 2021 at 6:26 PM falkenad ***@***.***> wrote: @mintakka <https://github.com/mintakka> Shouldn't the flash size be 16 as they're 25Q128 flash chips? IE: #define TOTAL_FLASH_SIZE 8 * 1024 * 1024 Should be: #define TOTAL_FLASH_SIZE 16 * 1024 * 1024 ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4411 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACNXKRIJTXTKHLKNTBDQGELTD2CPRANCNFSM4ZGVMNRA> .

[tannewt]

Thanks for the definition! Please rename the folder to sparkfun_thingplus_rp2040 because thingplus is a name used for the form factor. You'll also need to add the board to .github/workflows/build.yml

[mintakka]

Thank you, I will make these changes and re-submit

…

On Mon, Mar 15, 2021 at 8:43 PM Scott Shawcroft ***@***.***> wrote: ***@***.**** requested changes on this pull request. Thanks for the definition! Please rename the folder to sparkfun_thingplus_rp2040 because thingplus is a name used for the form factor. You'll also need to add the board to .github/workflows/build.yml ------------------------------ In ports/raspberrypi/boards/sparkfun_thingplus/mpconfigboard.h <#4411 (comment)> : > +#define MICROPY_HW_BOARD_NAME "Sparkfun ThingPlus RP2040" +#define MICROPY_HW_MCU_NAME "rp2040" + +#define MICROPY_HW_NEOPIXEL (&pin_GPIO8) + +#define DEFAULT_I2C_BUS_SCL (&pin_GPIO7) +#define DEFAULT_I2C_BUS_SDA (&pin_GPIO6) + +#define DEFAULT_SPI_BUS_SCK (&pin_GPIO14) +#define DEFAULT_SPI_BUS_MOSI (&pin_GPIO15) +#define DEFAULT_SPI_BUS_MISO (&pin_GPIO12) + +#define DEFAULT_UART_BUS_RX (&pin_GPIO1) +#define DEFAULT_UART_BUS_TX (&pin_GPIO0) + +// Flash chip is GD25Q64 connected over QSPI ⬇️ Suggested change -// Flash chip is GD25Q64 connected over QSPI +// Flash chip is GD25Q128 connected over QSPI ------------------------------ In ports/raspberrypi/boards/sparkfun_thingplus/mpconfigboard.mk <#4411 (comment)> : > +USB_VID = 0x239A +USB_PID = 0x80F2 ⬇️ Suggested change -USB_VID = 0x239A -USB_PID = 0x80F2 +USB_VID = 0x1B4F +USB_PID = 0x0025 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4411 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACNXKRIBBESDAIFXJ4L67TTTD2ST7ANCNFSM4ZGVMNRA> .

[mintakka]

revised pull request with requested changes

[mintakka]

@tannewt - I've addressed the required changes and I think it is ready for re-review

[tannewt]

A few minor things. Sorry I didn't see them in the first round of reviewing.

[mintakka]

All change requests incorporated

[mintakka]

Those are great catches, thanks!

[mintakka]

aligned board name in boards.yml with the folder name for the board in ports/raspberrypi/boards

[mintakka]

Alright, looks like the build checks all passed now. I think this is ready for review.

[jepler]

Thank you! Github tells me this is your first pull request to any repo, congratulations on that as well.

looks like the items were all addressed

[mintakka]

awesome, thanks!