Skip to content

Fix output overflow and make help translatable #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 10, 2018
Merged

Fix output overflow and make help translatable #1325

merged 2 commits into from
Nov 10, 2018

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Nov 10, 2018

No description provided.

@tannewt tannewt added this to the 4.0 Alpha milestone Nov 10, 2018
jerryneedell
jerryneedell reviewed Nov 10, 2018
View reviewed changes
Copy link
Collaborator

@jerryneedell jerryneedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on metro_m4_express -- issue with truncated output resolved.

dhalbert
dhalbert approved these changes Nov 10, 2018
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Saw the discord discussion.

@dhalbert dhalbert merged commit 50f5d27 into adafruit:master Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryneedell jerryneedell jerryneedell left review comments

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
atmel-samd bug nordic
Projects
None yet
Milestone
4.0 Alpha
Development

Successfully merging this pull request may close these issues.
3 participants
@tannewt @dhalbert @jerryneedell