Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging problems #215

Open
elpekenin opened this issue Jun 8, 2024 · 0 comments
Open

Packaging problems #215

elpekenin opened this issue Jun 8, 2024 · 0 comments

Comments

@elpekenin
Copy link
Contributor

elpekenin commented Jun 8, 2024

As diagnosed/solved on discord earlier today (you can thank my rf"..." later 😉)

With the current configuration of actions, if the "compilation" to .mpy fails, the zip is not generated and circup will get broken.

On this very situation it was due to me using a feature that mpy-cross does not support (raw fstring), which caused the process to error out. However i wouldnt be surprised if a fail somewhere else in the pipeline also causes this kind of problem.

Probably the easier and best solution is to do some fallback logic as in:

try:
    latest_zip = run_pipeline()
except:
    latest_zip = previous_one

But since i have no idea about GHA (nor perms to do anything) i'm simply noting this so it doesnt get forgotten far in the chat's history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant