Skip to content

Commit a00df83

Browse files
committed
review fixes; tested both with the full range of values. catches below and above range as errors.
1 parent 1dedc3d commit a00df83

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

adafruit_trellis.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ def blink_rate(self):
172172

173173
@blink_rate.setter
174174
def blink_rate(self, rate):
175-
if not 0 < rate > 3:
175+
if not 0 <= rate <= 3:
176176
raise ValueError('Blink rate must be an integer in the range: 0-3')
177177
rate = rate & 0x03
178178
self._blink_rate = rate
@@ -188,7 +188,7 @@ def brightness(self):
188188

189189
@brightness.setter
190190
def brightness(self, brightness):
191-
if not 0 < brightness > 15:
191+
if not 0 <= brightness <= 15:
192192
raise ValueError('Brightness must be an integer in the range: 0-15')
193193
brightness = brightness & 0x0F
194194
self._brightness = brightness

0 commit comments

Comments
 (0)