address review comments

Author: samatjain

adafruit_tinylora/adafruit_tinylora.py

@@ -417,6 +417,3 @@ def _write_u8(self, address: registeraddress, val: int) -> None:
             self._BUFFER[1] = val
             # pylint: disable=no-member
             device.write(self._BUFFER, end=2)
-            # pylint: disable=no-member
-            device.write(self._BUFFER, end=2)
-            device.write(self._BUFFER, end=2)

adafruit_tinylora/adafruit_tinylora_encryption.py

@@ -30,25 +30,8 @@ def xtime(col: int) -> int:
 
 
 # AES S-box
-# NOTE(typing): Each of these is 16b, can use bytearray16 here
-S_BOX: Tuple[
-    bytes,
-    bytes,
-    bytes,
-    bytes,
-    bytes,
-    bytes,
-    bytes,
-    bytes,
-    bytes,
-    bytes,
-    bytes,
-    bytes,
-    bytes,
-    bytes,
-    bytes,
-    bytes,
-] = (
+# NOTE(typing): Each of these 16 items is 16b, can use bytearray16 here
+S_BOX: Tuple[bytes, ...] = (
     b"c|w{\xf2ko\xc50\x01g+\xfe\xd7\xabv",
     b"\xca\x82\xc9}\xfaYG\xf0\xad\xd4\xa2\xaf\x9c\xa4r\xc0",
     b"\xb7\xfd\x93&6?\xf7\xcc4\xa5\xe5\xf1q\xd81\x15",

examples/tinylora_simpletest.py

@@ -34,10 +34,10 @@
 # rst = digitalio.DigitalInOut(board.RFM9X_RST)
 
 # TTN Device Address, 4 Bytes, MSB
-devaddr = bytearray4([0x00, 0x00, 0x00, 0x00])
+devaddr: bytearray4 = bytearray([0x00, 0x00, 0x00, 0x00])
 
 # TTN Network Key, 16 Bytes, MSB
-nwkey = bytearray16(
+nwkey: bytearray16 = bytearray(
     [
         0x00,
         0x00,
@@ -59,7 +59,7 @@
 )
 
 # TTN Application Key, 16 Bytess, MSB
-app = bytearray16(
+app: bytearray16 = bytearray(
     [
         0x00,
         0x00,
@@ -85,7 +85,7 @@
 lora = TinyLoRa(spi, cs, irq, rst, ttn_config)
 
 while True:
-    data = bytearray4(b"\x43\x57\x54\x46")
+    data: bytearray4 = bytearray(b"\x43\x57\x54\x46")
     print("Sending packet...")
     lora.send_data(data, len(data), lora.frame_counter)
     print("Packet sent!")

examples/tinylora_simpletest_si7021.py

@@ -42,10 +42,10 @@
 # rst = digitalio.DigitalInOut(board.RFM9X_RST)
 
 # TTN Device Address, 4 Bytes, MSB
-devaddr = bytearray4([0x00, 0x00, 0x00, 0x00])
+devaddr: bytearray4 = bytearray([0x00, 0x00, 0x00, 0x00])
 
 # TTN Network Key, 16 Bytes, MSB
-nwkey = bytearray16(
+nwkey: bytearray16 = bytearray(
     [
         0x00,
         0x00,
@@ -67,7 +67,7 @@
 )
 
 # TTN Application Key, 16 Bytess, MSB
-app = bytearray16(
+app: bytearray16 = bytearray(
     [
         0x00,
         0x00,

examples/tinylora_simpletest_single_channel.py

@@ -31,10 +31,10 @@
 # rst = digitalio.DigitalInOut(board.RFM9X_RST)
 
 # TTN Device Address, 4 Bytes, MSB
-devaddr = bytearray4([0x00, 0x00, 0x00, 0x00])
+devaddr: bytearray4 = bytearray([0x00, 0x00, 0x00, 0x00])
 
 # TTN Network Key, 16 Bytes, MSB
-nwkey = bytearray16(
+nwkey: bytearray16 = bytearray(
     [
         0x00,
         0x00,
@@ -56,7 +56,7 @@
 )
 
 # TTN Application Key, 16 Bytess, MSB
-app = bytearray16(
+app: bytearray16 = bytearray(
     [
         0x00,
         0x00,