Skip to content

Add french layout (with example) #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add french layout (with example) #54

wants to merge 3 commits into from

Conversation

@remisarrailh
Copy link

@remisarrailh remisarrailh commented Nov 4, 2020

No description provided.

@remisarrailh
Copy keyboard_layout_en to keyboard_layout_fr
025f763
@remisarrailh
Add french layout based on matthgyver/Arduino-Keyboard-FR
7a96fc8 
- ALTGR flag (needed for some characters)
- Extended Ascii (only needed characters)
- Circumflex accent is not working (âêîôû)
@remisarrailh
Add example / test for french layout
2b36a4f
@tannewt tannewt requested a review from dhalbert November 4, 2020 18:13
@dhalbert
Copy link
Collaborator

dhalbert commented Nov 4, 2020

Hi, this is very nice. Sadly, this library is frozen into various builds (especially CPX), and adding significantly more code to the library makes the frozen version of the library no longer fit on those builds.

This issue came up with a previous PR: see #46 and #53. If the KeyboardLayout class is refactored into a common class and then language specific pieces (either by subclassing or composition), then we can create new libraries for other keyboard layouts. They would be in separate repos.

@remisarrailh
Copy link
Author

remisarrailh commented Nov 5, 2020

OK, I'll wait until KeyboardLayout class is refactored. 👍

In the meantime, if someone want to use the french layout
You can find Adafruit_hid library (with french layout only) 6.x-mpy-20201105 here.
Adafruit_HID FR

I'm working on examples for Circuit Python in french for my workshop at Labsud (that's why I need it)
https://github.com/usini/CircuitPython_Exemples
I'll probably translates these, afterwards.

@kattni
Copy link
Contributor

kattni commented Dec 9, 2020

Closing this for now. We can revisit it once we have refactored things.

@kattni kattni closed this Dec 9, 2020
@AngainorDev
Copy link

AngainorDev commented Mar 18, 2021

Gave a try at refactoring with ancestor and including your french layout.
Working but likely to need further work
https://github.com/AngainorDev/Adafruit_CircuitPython_HID/tree/layouts/adafruit_hid

@dhalbert dhalbert mentioned this pull request Jun 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhalbert dhalbert Awaiting requested review from dhalbert

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@remisarrailh @dhalbert @kattni @AngainorDev