Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: adafruit/Adafruit_CircuitPython_GFX
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ed5a3d691bca3f7385db609e3f4796a7ddc40791
Choose a base ref
...
head repository: adafruit/Adafruit_CircuitPython_GFX
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 445b09ff8c1ff497a08923d7424f1eb0a98b0bb4
Choose a head ref
  • 5 commits
  • 4 files changed
  • 3 contributors

Commits on May 5, 2023

  1. fix fill_triangle bug issue #33

    This fix for issue #33 replaces the for loop at lines 283 to 291 with a while loop so that the y variable is properly incremented between the loops to fill the top and bottom parts of the triangle. This avoids screen row at y0 being drawn twice, and corrects the shape of the triangle. The changes to lines 278 to 282 (as numbered after the fix) initiate the two loops in a way that addresses issue #22 where a triangle with a flat bottom edge was not drawn correctly.
    
    This fix has been implemented in the derived repository  [framebuf2](https://github.com/peter-l5/framebuf2) which applies the algorithm here and has been  tested with the following code. (Note that `f=True` parameter draws a filled triangle in this implementation.)
    ```
        for z in range(3,123+1,20):
            for x in range(10,120+1,20):
                for y in range(0,128):
                    display.fill(0)
                    display.triangle(x,y,30,z,90,63,c=1,f=True)
                    display.show()
    ```
    peter-l5 authored May 5, 2023
    Configuration menu
    Copy the full SHA
    2e7d56f View commit details
    Browse the repository at this point in the history

Commits on May 6, 2023

  1. Configuration menu
    Copy the full SHA
    599db1b View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Update pre-commit hooks

    Signed-off-by: Tekktrik <tekktrik@gmail.com>
    tekktrik committed May 10, 2023
    Configuration menu
    Copy the full SHA
    bc8e727 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. Run pre-commit

    tekktrik committed May 11, 2023
    Configuration menu
    Copy the full SHA
    6e6bdd0 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #34 from peter-l5/main

    fix fill_triangle bug issue #33
    dhalbert authored May 11, 2023
    Configuration menu
    Copy the full SHA
    445b09f View commit details
    Browse the repository at this point in the history
Loading