Skip to content

Fix Build CI issue #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 31, 2022
Merged

Fix Build CI issue #166

merged 2 commits into from
May 31, 2022

Conversation

tekktrik
Copy link
Member

More specifically defined target references for Sphinx to resolve the Build CI issue!

@tekktrik tekktrik requested a review from a team May 31, 2022 02:32
dhalbert
dhalbert approved these changes May 31, 2022
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

So is Sphinx now complaining the originals are ambiguous?

@tekktrik
Copy link
Member Author

Yeah, exactly

@tekktrik tekktrik merged commit 922a5ab into adafruit:main May 31, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 31, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@7c4e110)
32cb243 
Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 8.3.1 from 8.3.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#166 from tekktrik/doc/specify-targets
  > Set language to "en" for documentation
  > Switch to inclusive terminology
  > Increase min lines similarity
  > Patch .pre-commit-config.yaml
  > change discord badge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tekktrik @dhalbert