Support all release types in inc operation
#18
+89
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dario-piotrowicz
force-pushed
the
dario/inc-followup
branch
from
126647e to
a14c73e
Compare
dario-piotrowicz
force-pushed
the
dario/inc-followup
branch
28 times, most recently
from
95b374e to
73f3dae
Compare
dario-piotrowicz
force-pushed
the
dario/inc-followup
branch
4 times, most recently
from
124f762 to
478ae74
Compare
dario-piotrowicz
force-pushed
the
dario/inc-followup
branch
from
c1700c5 to
304a0ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the remaining release types that can be passed to the
incfunction, making theincfunction quite completeOne noticeable thing I didn't do is supporting prerelease increments on versions which prereleases are not integers as that looks quite complex to me and something that I would like to do as a followup