Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop printing pokemon names and download full dataset #10

Closed
quentinmarolleau opened this issue Nov 10, 2022 · 3 comments
Closed

Stop printing pokemon names and download full dataset #10

quentinmarolleau opened this issue Nov 10, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@quentinmarolleau
Copy link

Hello, thanks for this very cool project.

I have the following config:
image

I want to add pokeshell random,1, random,2, random,3, random random random to my fish_greeting.fish function
to display a random team of 6 pokemons when opening a new terminal emulator window.

image

First, it would be nice to have the possibility not to display the disgracious list of pokemon names, on the top of the window.

Then, is there a way to force the downloading of the full dataset of sprites in the .cache directory, in order to always have a faster printing?

@acxz
Copy link
Owner

acxz commented Nov 10, 2022

These are some good ideas!

It should be simple enough to add a flag to disable the printing of the name.
For downloading the full dataset I can add some scripts that when run will download all the files associated with that option. For example ./download-small-sprites.sh, ./download-big-sprites.sh, ./download-animated-sprites.sh.

Since holiday season is coming up, I don't know when I'll get around to adding this tho. But I'll def add it to the roadmap.

@acxz acxz added the enhancement New feature or request label Nov 10, 2022
@quentinmarolleau
Copy link
Author

Thanks, that is exactly the type of ideas I was thinking about.

Unfortunately I am not used to shell script developpement, and I do not think that I could help with this...

@acxz
Copy link
Owner

acxz commented Nov 11, 2024

Showing the names is now behind a flag (-n, --show-name). You shouldn't see any more names unless you want to. 94963dd

I'll close this issue now, for the offline dataset, see: #9

image

image

@acxz acxz closed this as completed Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants