Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom helper methods aren't rendered in 1.2.0 #120

Closed
seanlinsley opened this issue Apr 11, 2019 · 0 comments · Fixed by #121
Closed

Custom helper methods aren't rendered in 1.2.0 #120

seanlinsley opened this issue Apr 11, 2019 · 0 comments · Fixed by #121

Comments

@seanlinsley
Copy link
Contributor

As of version 1.2.0, this helper method no longer renders:

# _form.html.arb
active_admin_form_for [:admin, resource] do |f|
  error_banner(f)

  # ...
end
# app/helpers/admin/application_helper.rb
module Admin::ApplicationHelper
  def error_banner(form)
    # ...

    form.semantic_errors
  end
end

When inlining the code, however, it does render.

# _form.html.arb
active_admin_form_for [:admin, resource] do |f|
  f.semantic_errors

  # ...
end

This was likely caused by #64, and is related to #119.

It's not clear if the issue is specific to using Arbre templates (as opposed to inlined forms in app/admin), or using custom helper methods (as opposed to Rails helper methods).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant