Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paginator #61

Merged
merged 3 commits into from
Oct 2, 2013
Merged

Paginator #61

merged 3 commits into from
Oct 2, 2013

Conversation

Zhomart
Copy link
Contributor

@Zhomart Zhomart commented Oct 2, 2013

Added tests for paginator

@elia
Copy link
Member

elia commented Oct 2, 2013

Awesome! Merging.

(Travis failure is a false negative)

@Zhomart
Copy link
Contributor Author

Zhomart commented Oct 2, 2013

Tests works fine on Ruby 2.0.0. But nokogiri's   works different on Ruby 1.9.3. I'll try to fix it

elia added a commit that referenced this pull request Oct 2, 2013
@elia
Merge pull request #61 from Zhomart/paginator
bba338a 
Paginator
@elia elia merged commit bba338a into activeadmin:master Oct 2, 2013
@elia
Copy link
Member

elia commented Oct 2, 2013

@Zhomart it's ok if I give you direct commit access? :)

@Zhomart
Copy link
Contributor Author

Zhomart commented Oct 3, 2013

Ok, I dont mind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zhomart @elia