Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to PRs linked to an issue should clear the stale attribute #804

Open
jsoref opened this issue Aug 29, 2022 · 8 comments
Open

Updates to PRs linked to an issue should clear the stale attribute #804

jsoref opened this issue Aug 29, 2022 · 8 comments
Labels
enhancement New feature or request investigation The issue is under investigation

Comments

@jsoref
Copy link

jsoref commented Aug 29, 2022

The problem

  1. actions/stale said an issue was stale docs-build fails on forks primer/view_components#1033 (comment) and marked it as stale docs-build fails on forks primer/view_components#1033 (comment)
  2. I made a PR that would close the issue docs-build fails on forks primer/view_components#1033 (reference)
  3. The bot did not remove its stale marker
  4. I had to add an extra comment to the issue: docs-build fails on forks primer/view_components#1033 (comment)

The solution

Ideally the bot should be able to recognize that a PR exists and is linked to the issue and remove the stale annotation. As stale-bot runs on a schedule, it can have access to pull requests and can therefore check to see if there are stale-issues with linked PRs and then check to see if those PRs have been touched since it last ran, and then remove the stale notice.

@jsoref jsoref added the enhancement New feature or request label Aug 29, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Sep 29, 2022
@jsoref
Copy link
Author

jsoref commented Sep 29, 2022

👎

@github-actions github-actions bot removed the Stale label Sep 30, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Oct 31, 2022
@jsoref
Copy link
Author

jsoref commented Oct 31, 2022

👎

@github-actions github-actions bot removed the Stale label Nov 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Dec 2, 2022
@jsoref
Copy link
Author

jsoref commented Dec 2, 2022

👎

@github-actions github-actions bot removed the Stale label Dec 3, 2022
@bilderbuchi
Copy link

In a similar vein, issue that have an open PR linked to them (like conda/conda-build#3170) should not be marked stale at all, imo. Otherwise, stale bot would close an issue that has a PR currently waiting that closes it.
If anything, the linked PR should be checked for staleness, as that has become the "upstream" datum of information concerning the issue in question.

@dsame dsame added the investigation The issue is under investigation label Aug 8, 2023
@dorner
Copy link

dorner commented Aug 10, 2023

I'm kind of shocked that this isn't the default behavior. I switched to this action because I assumed it was. ☹️ In general if an issue has a linked PR, and that PR is active, that should be enough to keep the issue itself "alive".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request investigation The issue is under investigation
Projects
None yet
Development

No branches or pull requests

4 participants