Rework pipenv caching test #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 3, 2022 19:19
brcrista
approved these changes
Apr 4, 2022
adilosa
added a commit
to adilosa/setup-python
that referenced
this pull request
Apr 19, 2022
* upstream/main: (33 commits) Fix virtual-env toolcache links Updated @actions/cache (actions#382) ci(workflow): add 'npm' cache for actions/setup-node in .github/workflows (actions#379) Cache hit output (actions#373) Add pyton-version to setup PyPy output (actions#365) Rework pipenv caching test (actions#375) Update README.md to fix setup-python version in example (actions#368) dist fix (actions#367) Cache on ghes (actions#363) Update dist Use `\n` instead of `os.EOL` Update dist Initialise pyproject.toml Build and format Remove console.log Remove unused file Reduce test matrix Parse values from poetry Release Add more tests ...
tdfacer
pushed a commit
to ifit/setup-python
that referenced
this pull request
Oct 7, 2025
* Rework python-pipenv-dependencies-caching test * Update Pipfile.lock hash in the tests * Rework python-pipenv-dependencies-caching-path test * Set location for pipenv test * Remove requests package from tests * Test pipenv without caching * Enable pipenv cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Pipenv cache tests are broken at the moment. Example of the failed run: link
In order to fix these tests:
numpyandpandaspackages to avoid of creating new pipenv environment each time (pipenv creates new environment if Pipfile is not exist). The versions ofnumpyandpandasare hardcoded in the Pipfile to avoid regenerating cache.Test build: link
Related issue:
#376
Check list: