-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.5 setup fails with an invalid certificate when running pip #866
Comments
I'm also able to reproduce this behavior in a self-hosted environment. |
There's an open issue on setup-python about the SSL certificate error. actions/setup-python#866
@andy-maier I believe you can use this "temporary fix" (using - uses: actions/setup-python@v5
with:
python-version: 3.5
env:
PIP_TRUSTED_HOST: "pypi.python.org pypi.org files.pythonhosted.org" Found it here https://stackoverflow.com/questions/25981703/pip-install-fails-with-connection-error-ssl-certificate-verify-failed-certi |
Hello @andy-maier, Thank you for creating this issue and we will look into it :) |
Previous commit didn't make it. See actions/setup-python#866
The Python 3.4.4 Windows MSI installation is also affected and also responds to the
Presumably pypi.org has reconfigured its servers with some new web-breaking security option so that older SSL implementations can't verify its certificate? If so the "temporary" work-around may be wrongly described. |
@joamag |
Immediately motivated by these builds breaking on GitHub Actions: actions/setup-python#866 but we also do not need to support Ubuntu 16.04 any longer. I think we should do one more release of ros_buildfarm, if possible, before allowing e.g. f-strings and other newer language features. But if ever there was a repo that wanted f-strings it's this one.
Immediately motivated by these builds breaking on GitHub Actions: actions/setup-python#866 but we also do not need to support Ubuntu 16.04 any longer. I think we should do one more release of ros_buildfarm, if possible, before allowing e.g. f-strings and other newer language features. But if ever there was a repo that wanted f-strings it's this one.
Since the point of the action is to install various versions of Python, end-of-life or not, you need to apply this workaround for the affected versions within the action itself. |
I agree, but adding these environment variables effectively ignores any SSL error, including MITM certificate mismatches. I feel like a |
Thank you for your suggestions. Unfortunately, it's not feasible for us to incorporate the proposed changes directly into the |
It's got more awkward to test in GHA (see actions/setup-python#866), and we advertised dropping support for < 3.6 in multipart 0.2 anyway.
According to actions/setup-python#866, this should fix the CERTIFICATE_VERIFY_FAILED error while trying to fetch the EOL-ed Python 3.5. Alternative: Remove support for Python 3.5.
Closes #130 by @GalaxySnail * Upgrade GitHub Actions, upgrade runtime to node20 [1] https://github.blog/changelog/2023-12-14-github-actions-artifacts-v4-is-now-generally-available/ [2] https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ [3] https://github.blog/news-insights/product-news/get-started-with-v4-of-github-actions-artifacts/ [4] https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md * Actions: upload hidden files [1] https://github.blog/changelog/2024-08-19-notice-of-upcoming-deprecations-and-breaking-changes-in-github-actions-runners/ [2] actions/upload-artifact#602 * Drop python 3.7 support on macOS macos-latest is currently an alias for macOS 14 Arm64, and python 3.7 is already EOL, so drop it on macOS. [1] actions/runner-images#9741 [2] https://github.com/actions/runner-images#available-images * Skip cert check on python 3.5 ref: actions/setup-python#866 * Actions: run monthly * Upgrade .python-version-default to 3.12 * Add python 3.13 to CI matrix
Description:
Python 3.5 setup fails with an invalid certificate when running pip.
This started happening a few days ago. 7 days ago it still worked.
From a today's run where it failed: https://github.com/zhmcclient/zhmc-ansible-modules/actions/runs/9076784995/job/24940262974
Action version:
v5
Platform:
Runner type:
Tools version:
Python 3.5
Repro steps:
To reproduce, use the setup-python action with Python 3.5.
Expected behavior:
Python 3.5 should be installed as it was 1 week ago.
Actual behavior:
See description, above.
The text was updated successfully, but these errors were encountered: