Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Install on Windows is very slow #393

Merged
merged 16 commits into from
Aug 3, 2023
Merged

Fix Install on Windows is very slow #393

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
930ff22
Fix Install on Windows is very slow
dsame Jul 11, 2023
93ae31f
Add unit test
dsame Jul 11, 2023
1c500a4
Improve readability
dsame Jul 11, 2023
c5c2a05
Add e2e test
dsame Jul 11, 2023
99ea9d4
fix lint
dsame Jul 11, 2023
d4fc988
Fix unit tests
dsame Jul 12, 2023
7eefc6e
Fix unit tests
dsame Jul 12, 2023
96a9554
limit to github hosted runners
dsame Jul 12, 2023
60dde96
test hosted version of go
dsame Jul 12, 2023
90cd2f9
AzDev environment
dsame Jul 17, 2023
00f551b
rename lnkSrc
dsame Jul 17, 2023
8998c68
refactor conditions
dsame Jul 17, 2023
42a70ec
improve tests
dsame Jul 18, 2023
d6ad0fa
refactoring
dsame Jul 20, 2023
59c54a4
Fix e2e test
dsame Jul 25, 2023
55bf2e2
improve isHosted readability
dsame Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix e2e test
  • Loading branch information
@dsame
dsame committed Jul 25, 2023
commit 59c54a4b0bd948e7a2b72fafdc5a687868385747
15 changes: 8 additions & 7 deletions .github/workflows/windows-validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: validate Windows installation
name: Validate Windows installation

on:
push:
Expand All @@ -13,15 +13,15 @@ on:
jobs:
create-link-if-not-default:
runs-on: windows-latest
name: 'Setup ${{ matrix.go }}, cache: ${{ matrix.cache }}'
name: 'Validate if symlink is created'
strategy:
matrix:
cache: [false, true]
go: [1.20.1]
steps:
- uses: actions/checkout@v3

- name: non-default-cache-${{ matrix.cache }}-${{ matrix.go }}
- name: 'Setup ${{ matrix.cache }}, cache: ${{ matrix.go }}'
uses: ./
with:
go-version: ${{ matrix.go }}
Expand Down Expand Up @@ -81,7 +81,7 @@ jobs:
shell: bash

dont-create-link-if-default:
name: 'Use default go, cache: ${{ matrix.cache }}'
name: 'Validate if symlink is not created for default go'
runs-on: windows-latest
needs: find-default-go
strategy:
Expand All @@ -90,12 +90,13 @@ jobs:
steps:
- uses: actions/checkout@v3

- uses: ./
- name: 'Setup default go, cache: ${{ matrix.cache }}'
uses: ./
with:
go-version: ${{ needs.find-default-go.outputs.version }}
cache: ${{ matrix.cache }}

- name: 'Drive C: should have Go installation'
- name: 'Drive C: should have Go installation, cache: ${{ matrix.cache}}'
run: |
size=$(du -m -s 'C:\hostedtoolcache\windows\go\${{ needs.find-default-go.outputs.version }}\x64'|cut -f1 -d$'\t')
if [ $size -eq 0 ];then
Expand All @@ -104,7 +105,7 @@ jobs:
fi
shell: bash

- name: 'Drive D: should not have Go installation'
- name: 'Drive D: should not have Go installation, cache: ${{ matrix.cache}}'
run: |
if [ -e 'D:\hostedtoolcache\windows\go\${{ needs.find-default-go.outputs.version }}\x64' ];then
echo 'D:\hostedtoolcache\windows\go\${{ needs.find-default-go.outputs.version }}\x64 should not exist for hosted version of go';
Expand Down
Loading