Register Runners against V2 servers #2505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luketomlinson
changed the title
jww3
reviewed
Mar 27, 2023
jww3
reviewed
Mar 27, 2023
jww3
approved these changes
Mar 28, 2023
8 tasks
nikola-jokic
pushed a commit
to nikola-jokic/runner
that referenced
this pull request
May 12, 2023
* Parse runners and send publicKey * wip * Fix conflicts * Cleanup * Cleanup * fix test * fix test * Add trace for broker message listener * Feedback * refactor * remove dead code * Remove old comment
AdamOlech
pushed a commit
to antmicro/runner
that referenced
this pull request
Aug 14, 2024
* Parse runners and send publicKey * wip * Fix conflicts * Cleanup * Cleanup * fix test * fix test * Add trace for broker message listener * Feedback * refactor * remove dead code * Remove old comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR registers runners against the new endpoint. The biggest changes are:
Sending the runner's public key, encoded as an XML string up to the registration call
Parsing the authorization object from the runner registration response and saves it for refreshing tokens
Saves the
ServerUrlV2in the RunnerSettings to connect to the new server for messages