Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem matchers with multiple severities don't match every result #1862

Open
xt0rted opened this issue Apr 30, 2022 · 3 comments
Open

Problem matchers with multiple severities don't match every result #1862

xt0rted opened this issue Apr 30, 2022 · 3 comments
Labels
bug Something isn't working Runner Bug Bug fix scope to the runner

Comments

@xt0rted
Copy link

xt0rted commented Apr 30, 2022

Describe the bug

If a problem matcher matches both errors and warnings and a build log contains mixed results not every result gets matched. Files with only errors or only warnings are matched correctly, but files with mixed results have only the first severity matched until the other severity is hit.

image

I ran into this while trying to add warning support to my Stylelint problem matcher action.

To Reproduce

Steps to reproduce the behavior:

  1. Register a problem matcher with two matchers, one with an error severity and one with a warning severity
  2. Emit both errors and warnings to the build log
  3. Not all results will be matched

Expected behavior

For every error and warning to be matched, even when both are in the same file's results.

Runner Version and Platform

Version of your runner? 2.290.1

OS of the machine running the runner? all

What's not working?

Not all matched build log lines are being highlighted.

Job Log Output

Sample repo showing the issue https://github.com/xt0rted-test/problem-matcher-test/actions/runs/2248762840

@xt0rted xt0rted added the bug Something isn't working label Apr 30, 2022
@ruvceskistefan ruvceskistefan added the Runner Bug Bug fix scope to the runner label May 6, 2022
@ruvceskistefan
Copy link
Contributor

Hi @xt0rted,

Thanks for reporting this issue! I've added it to the board, so we'll investigate it in the coming period and get back to you when we have more information.

Copy link
Contributor

This issue is stale because it has been open 365 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Nov 27, 2023
@xt0rted
Copy link
Author

xt0rted commented Nov 27, 2023

Still an issue last I checked.

@github-actions github-actions bot removed the Stale label Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Runner Bug Bug fix scope to the runner
Projects
None yet
Development

No branches or pull requests

2 participants