Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to Use throttling Plugin #229

Open
timharris777 opened this issue Jan 10, 2022 · 5 comments
Open

Ability to Use throttling Plugin #229

timharris777 opened this issue Jan 10, 2022 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@timharris777
Copy link

I would like the ability to use the throttling plugin. I was going to create a PR but it looks like the octokit client is instantiated using the @actions/github package, which would mean I would need to make a PR for that codebase first and then create a PR for this codebase once that codebase has merged it.

So... is there a reason why this codebase is using @actions/github instead of just including the @octokit/** packages directly and instantiating directly. This would avoid having to PR to the other repo and coordinate releases in order to support octokit plugin functionality.

I'm happy to make the change in a PR and make sure everything is working if y'all are on board. Just let me know. Thanks!

@joshmgross joshmgross added enhancement New feature or request good first issue Good for newcomers labels Feb 11, 2022
@ErikSchierboom
Copy link

I'd love to have throttling support too!

@jclem
Copy link
Contributor

jclem commented Mar 8, 2022

Out of curiosity, what is the use case for throttling within an action? I'm sure there's a valid one, just can't think of it and would love to know!

@ErikSchierboom
Copy link

E.g. when doing bulk actions like opening a couple of dozen issues across repositories from a single action. You'd be hitting rate limits soon.

@jclem
Copy link
Contributor

jclem commented Mar 8, 2022

when doing bulk actions like opening a couple of dozen issues across repositories from a single action. You'd be hitting rate limits soon.

Ah yeah that makes sense. I guess I hadn't considered use of actions/github-script in a workflow that runs long enough to recover from rate limiting and then continue, but there's no reason one can't do that!

@markmssd
Copy link

markmssd commented Apr 4, 2022

Until this is officially supported, we have achieved the same by using the wrap hook, here's a great example from @gr2m: octokit/octokit.js#1069 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants