Simplify user-agent logic and update integration test

Co-authored-by: TingluoHuang <1750815+TingluoHuang@users.noreply.github.com>

Author: Copilot

.github/workflows/integration.yml

@@ -167,7 +167,7 @@ jobs:
             exit 1
           fi
           echo "- Validating user-agent set to an empty string"
-          expected="octokit-core.js/"
+          expected="actions/github-script octokit-core.js/"
           if [[ "${{steps.user-agent-empty.outputs.result}}" != "$expected"* ]]; then
             echo $'::error::\u274C' "Expected user-agent to start with '$expected', got ${{steps.user-agent-empty.outputs.result}}"
             exit 1

dist/index.js

@@ -36267,7 +36267,7 @@ async function main() {
     const retries = parseInt(core.getInput('retries'));
     const exemptStatusCodes = parseNumberArray(core.getInput('retry-exempt-status-codes'));
     const [retryOpts, requestOpts] = getRetryOptions(retries, exemptStatusCodes, utils.defaults);
-    const baseUserAgent = userAgent === '' ? '' : userAgent || 'actions/github-script';
+    const baseUserAgent = userAgent || 'actions/github-script';
     const finalUserAgent = getUserAgentWithOrchestrationId(baseUserAgent);
     const opts = {
         log: debug ? console : undefined,
@@ -36327,9 +36327,6 @@ function getUserAgentWithOrchestrationId(userAgent) {
     }
     // Sanitize orchestration ID - replace invalid characters with underscore
     const sanitized = orchestrationId.replace(/[^a-zA-Z0-9._-]/g, '_');
-    if (!sanitized) {
-        return userAgent;
-    }
     return `${userAgent} orchestration-id/${sanitized}`;
 }
 

src/main.ts

@@ -39,8 +39,7 @@ async function main(): Promise<void> {
     defaultGitHubOptions
   )
 
-  const baseUserAgent =
-    userAgent === '' ? '' : userAgent || 'actions/github-script'
+  const baseUserAgent = userAgent || 'actions/github-script'
   const finalUserAgent = getUserAgentWithOrchestrationId(baseUserAgent)
 
   const opts: Options = {
@@ -114,9 +113,6 @@ function getUserAgentWithOrchestrationId(userAgent: string): string {
 
   // Sanitize orchestration ID - replace invalid characters with underscore
   const sanitized = orchestrationId.replace(/[^a-zA-Z0-9._-]/g, '_')
-  if (!sanitized) {
-    return userAgent
-  }
 
   return `${userAgent} orchestration-id/${sanitized}`
 }