Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a PR check for default values in action.yml #723

Closed
febuiles opened this issue Mar 22, 2024 · 1 comment
Closed

Create a PR check for default values in action.yml #723

febuiles opened this issue Mar 22, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers Stale

Comments

@febuiles
Copy link
Contributor

Recent changes inadvertently broke the external configuration capabilities of our Action by introducing default values in action.yml, as detailed in this pull request.

It's clear that merely commenting at the top of a file isn't sufficient to prevent these issues. To address this, I suggest implementing a check for every pull request that edits action.yml to ensure no new default values are added, except for the token. We can achieve this with either an NPM script or a shell command.

Copy link

github-actions bot commented Oct 4, 2024

👋 This issue has been closed by stalebot because it has been open with no activity for over 180 days. Please see CONTRIBUTING.md for more policy details.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Stale
Projects
None yet
Development

No branches or pull requests

1 participant