fix prettier glob pattern #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
kpeterson-sf
pushed a commit
to sf-bt-neteng/checkout
that referenced
this pull request
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that if you don't quote the glob pattern it doesn't reach past the first level.
After this change
src/misc/generate-docs.tswill be included:npm run format >> checkout@2.0.2 format /Users/peter.evans/git/checkout >> prettier --write '**/*.ts' __test__/git-auth-helper.test.ts 303ms __test__/git-directory-helper.test.ts 84ms __test__/git-version.test.ts 23ms __test__/input-helper.test.ts 22ms __test__/ref-helper.test.ts 28ms __test__/retry-helper.test.ts 12ms src/fs-helper.ts 9ms src/git-auth-helper.ts 64ms src/git-command-manager.ts 79ms src/git-directory-helper.ts 19ms src/git-source-provider.ts 30ms src/git-source-settings.ts 10ms src/git-version.ts 17ms src/github-api-helper.ts 22ms src/input-helper.ts 27ms src/main.ts 11ms +src/misc/generate-docs.ts 23ms src/ref-helper.ts 18ms src/regexp-helper.ts 6ms src/retry-helper.ts 9ms src/state-helper.ts 7ms src/url-helper.ts 5ms