Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checkout head commit of PR #102

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Fix checkout head commit of PR #102

merged 1 commit into from
Dec 10, 2019

Conversation

mrrobot47
Copy link
Contributor

@mrrobot47 mrrobot47 commented Dec 10, 2019 •
edited
Loading

github.event.after fails when Pull Request has just been created. At that time, after or before commit sha's do not exist. They exist during PR synchronize action.

Whereas github.event.pull_request.head.sha will work for both PR opened action as well as PR synchronize action.

Ref: #61

@mrrobot47
Document update: Checkout PR head sha
a4ec47d 
Signed-off-by: Riddhesh Sanghvi <riddhesh237@gmail.com>
@mrrobot47 mrrobot47 mentioned this pull request Dec 10, 2019
Closed
@ericsciple
Copy link
Contributor

@mrrobot47 thanks!

@ericsciple ericsciple merged commit cab3161 into actions:master Dec 10, 2019
@mrrobot47 mrrobot47 deleted the fix/checkout-pr-head branch December 11, 2019 04:40
@mliszcz mliszcz mentioned this pull request Jun 15, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrrobot47 @ericsciple