Clarify that the `restore-keys` input is a string in the docs by x612skm · Pull Request #1434 · actions/cache

x612skm · 2024-07-18T17:07:50Z

Previously the description of restore-keys confusingly implied that it might accept a YAML list, which is wrong. This patch corrects that to say, it's a string.

Closes #1173

x612skm · 2024-07-19T11:14:10Z

@bethanyj28, mind taking a look at this PR?

joshmgross · 2024-07-31T16:55:05Z

 * `key` - An explicit key for a cache entry. See [creating a cache key](#creating-a-cache-key).
 * `path` - A list of files, directories, and wildcard patterns to cache and restore. See [`@actions/glob`](https://github.com/actions/toolkit/tree/main/packages/glob) for supported patterns.
-* `restore-keys` - An ordered list of prefix-matched keys to use for restoring stale cache if no cache hit occurred for key.
+* `restore-keys` - An ordered multiline string listing the prefix-matched keys, that are used for restoring stale cache if no cache hit occurred for key.


Can you update

cache/restore/action.yml

Lines 11 to 13 in e47d9f9

restore-keys:

description: 'An ordered list of keys to use for restoring stale cache if no cache hit occurred for key. Note `cache-hit` returns false in this case.'

required: false

and

cache/action.yml

Lines 11 to 13 in e47d9f9

restore-keys:

description: 'An ordered list of keys to use for restoring stale cache if no cache hit occurred for key. Note `cache-hit` returns false in this case.'

required: false

to match this new description?

Done @joshmgross Mind taking a relook?

As previously the restore-keys were defined as an ordered lists which is wrong as per the issue description where the actual format is a multi-line string with one key per line.

While at the PR review it's been identified there's a need for a space between the sentence ``` An ordered multiline string listing the prefix-matched keys,that are used for restoring stale cache if no cache hit occurred for key. ``` where it's written as "prefix-matched keys,that are" this commit will address the review comment and introduce a space between "prefix-matched keys, that are" and change the sentence to ``` An ordered multiline string listing the prefix-matched keys, that are used for restoring stale cache if no cache hit occurred for key. ```

…/action.yml

…s#1434) * Fix Description for restore-keys at Readme As previously the restore-keys were defined as an ordered lists which is wrong as per the issue description where the actual format is a multi-line string with one key per line. * Added a space between the sentence of restore-keys description While at the PR review it's been identified there's a need for a space between the sentence ``` An ordered multiline string listing the prefix-matched keys,that are used for restoring stale cache if no cache hit occurred for key. ``` where it's written as "prefix-matched keys,that are" this commit will address the review comment and introduce a space between "prefix-matched keys, that are" and change the sentence to ``` An ordered multiline string listing the prefix-matched keys, that are used for restoring stale cache if no cache hit occurred for key. ``` * Change restore-keys description at cache/restore/action.yml and cache/action.yml

@v4

* update documentation to use <action>@v4 * Update README.md and use v4 of checkout action (actions#1437) Update examples to use latest available checkout action v4. * Explicit use bash for Windows (actions#1377) Co-authored-by: Josh Gross <joshmgross@github.com> * Fix cache-hit output when cache missed (actions#1404) * fix: cache-hit output * fix: Output chache hit timing * fix: Output chache hit timing --------- Co-authored-by: Josh Gross <joshmgross@github.com> * Clarify that the `restore-keys` input is a string in the docs (actions#1434) * Fix Description for restore-keys at Readme As previously the restore-keys were defined as an ordered lists which is wrong as per the issue description where the actual format is a multi-line string with one key per line. * Added a space between the sentence of restore-keys description While at the PR review it's been identified there's a need for a space between the sentence ``` An ordered multiline string listing the prefix-matched keys,that are used for restoring stale cache if no cache hit occurred for key. ``` where it's written as "prefix-matched keys,that are" this commit will address the review comment and introduce a space between "prefix-matched keys, that are" and change the sentence to ``` An ordered multiline string listing the prefix-matched keys, that are used for restoring stale cache if no cache hit occurred for key. ``` * Change restore-keys description at cache/restore/action.yml and cache/action.yml * Add workflow file for publishing releases to immutable action package This workflow file publishes new action releases to the immutable action package of the same name as this repo. This is part of the Immutable Actions project which is not yet fully released to the public. First party actions like this one are part of our initial testing of this feature. * Deprecate `save-always` input (actions#1452) The `save-always` input added in v4 is not working as intended due to `post-if` expressions not supporting the input context. To avoid breaking users who have already added this input to their workflows, it is being deprecated now and will be removed in the next major version (v5). See actions#1315 for more details. * Fix typo: depening -> depending (actions#1462) Co-authored-by: Josh Gross <joshmgross@github.com> * restore action's README now references v4 instead of v3 (actions#1445) Co-authored-by: Josh Gross <joshmgross@github.com> * Prepare `4.1.0` release (actions#1464) * Restore original behavior of `cache-hit` output (actions#1467) * Restore original behavior of `cache-hit` output * Bump version to 4.1.1 * Add Bun example (actions#1456) * Add Bun example * Fix Bun Windows example * Revise `isGhes` logic * ran `npm run build` * appease the linter * added unit tests * Bump braces from 3.0.2 to 3.0.3 Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * Create dependabot.yml * Prepare release 4.1.2 * Bump actions/checkout from 3 to 4 Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Bump actions/stale from 3 to 9 Bumps [actions/stale](https://github.com/actions/stale) from 3 to 9. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v3...v9) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Bump actions/setup-node from 3 to 4 Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3 to 4. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v3...v4) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github/codeql-action from 2 to 3 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2 to 3. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@v2...v3) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Upgrade @actions/cache to 4.0.0 * Update RELEASES.md * Upgrade @vercel/ncc to 0.38.3 * Upgrade @actions/core to 1.11.1 and other deps * Add licensed output * Add reviewed licensed packages * Add lodash to list of reviewed licenses * Add licensed output * Rerun CI * Add 3.4.0 release notes * Correct GitHub Spelling in caching-strategies.md (actions#1526) GitHub was spelled incorrectly 3 lines under the Understanding how to choose path section * docs: Make the "always save prime numbers" example more clear (actions#1525) * Update force deletion docs due a recent deprecation (actions#1500) * fix: update force deletion docs due a recent deprecation * fix: applied josh's suggestions --------- Co-authored-by: Josh Gross <joshmgross@github.com> * bump @actions/cache to v4.0.1 * Update publish-immutable-actions.yml * bump @actions/cache to v4.0.2, prep for v4.2.2 release * add changes * changed * mask whole url * debugging * type * artifact changes * update cache package to mask whole sas to the end of the line * mask * update * latest test before pr * updated cache with latest changes * updates * new package * update cache with main * Update to use the latest version of the cache package to obfuscate the SAS * Update releases.md * Update README.md * fix: fix --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: todgru <todgru@gmail.com> Co-authored-by: P. Ottlinger <ottlinger@users.noreply.github.com> Co-authored-by: Oleg A. <t0rr@mail.ru> Co-authored-by: Josh Gross <joshmgross@github.com> Co-authored-by: r4mimu <52129983+fchimpan@users.noreply.github.com> Co-authored-by: Soubhik Kumar Mitra <59209034+x612skm@users.noreply.github.com> Co-authored-by: Bassem Dghaidi <568794+Link-@users.noreply.github.com> Co-authored-by: Joel Ambass <Jcambass@users.noreply.github.com> Co-authored-by: mackey0225 <masaki.asano0225@gmail.com> Co-authored-by: Eman Resu <78693624+quatquatt@users.noreply.github.com> Co-authored-by: Jan T. Sott <git@idleberg.com> Co-authored-by: John Wesley Walker III <81404201+jww3@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: janco-absa <janco.bester@absa.africa> Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com> Co-authored-by: Alessandro Sebastiani <sebbalex@users.noreply.github.com> Co-authored-by: Rob Herley <robherley@github.com> Co-authored-by: Salman Chishti <salmanmkc@GitHub.com> Co-authored-by: Ben De St Paer-Gotch <nebuk89@github.com>

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [actions/cache](https://github.com/actions/cache) | major | `v4` → `v5.0.5` | --- ### Release Notes <details> <summary>actions/cache (actions/cache)</summary> ### [`v5.0.5`](https://github.com/actions/cache/releases/tag/v5.0.5) [Compare Source](actions/cache@v5.0.4...v5.0.5) #### What's Changed - Update ts-http-runtime dependency by [@yacaovsnc](https://github.com/yacaovsnc) in [#1747](actions/cache#1747) **Full Changelog**: <actions/cache@v5...v5.0.5> ### [`v5.0.4`](https://github.com/actions/cache/releases/tag/v5.0.4) [Compare Source](actions/cache@v5.0.3...v5.0.4) #### What's Changed - Add release instructions and update maintainer docs by [@Link-](https://github.com/Link-) in [#1696](actions/cache#1696) - Potential fix for code scanning alert no. 52: Workflow does not contain permissions by [@Link-](https://github.com/Link-) in [#1697](actions/cache#1697) - Fix workflow permissions and cleanup workflow names / formatting by [@Link-](https://github.com/Link-) in [#1699](actions/cache#1699) - docs: Update examples to use the latest version by [@XZTDean](https://github.com/XZTDean) in [#1690](actions/cache#1690) - Fix proxy integration tests by [@Link-](https://github.com/Link-) in [#1701](actions/cache#1701) - Fix cache key in examples.md for bun.lock by [@RyPeck](https://github.com/RyPeck) in [#1722](actions/cache#1722) - Update dependencies & patch security vulnerabilities by [@Link-](https://github.com/Link-) in [#1738](actions/cache#1738) #### New Contributors - [@XZTDean](https://github.com/XZTDean) made their first contribution in [#1690](actions/cache#1690) - [@RyPeck](https://github.com/RyPeck) made their first contribution in [#1722](actions/cache#1722) **Full Changelog**: <actions/cache@v5...v5.0.4> ### [`v5.0.3`](https://github.com/actions/cache/releases/tag/v5.0.3) [Compare Source](actions/cache@v5.0.2...v5.0.3) #### What's Changed - Bump `@actions/cache` to v5.0.5 (Resolves: <https://github.com/actions/cache/security/dependabot/33>) - Bump `@actions/core` to v2.0.3 **Full Changelog**: <actions/cache@v5...v5.0.3> ### [`v5.0.2`](https://github.com/actions/cache/releases/tag/v5.0.2): v.5.0.2 [Compare Source](actions/cache@v5.0.1...v5.0.2) ### v5.0.2 #### What's Changed When creating cache entries, 429s returned from the cache service will not be retried. ### [`v5.0.1`](https://github.com/actions/cache/releases/tag/v5.0.1) [Compare Source](actions/cache@v5...v5.0.1) > \[!IMPORTANT] > **`actions/cache@v5` runs on the Node.js 24 runtime and requires a minimum Actions Runner version of `2.327.1`.** > > If you are using self-hosted runners, ensure they are updated before upgrading. *** ### v5.0.1 #### What's Changed - fix: update [@actions/cache](https://github.com/actions/cache) for Node.js 24 punycode deprecation by [@salmanmkc](https://github.com/salmanmkc) in [#1685](actions/cache#1685) - prepare release v5.0.1 by [@salmanmkc](https://github.com/salmanmkc) in [#1686](actions/cache#1686) ### v5.0.0 #### What's Changed - Upgrade to use node24 by [@salmanmkc](https://github.com/salmanmkc) in [#1630](actions/cache#1630) - Prepare v5.0.0 release by [@salmanmkc](https://github.com/salmanmkc) in [#1684](actions/cache#1684) **Full Changelog**: <actions/cache@v5...v5.0.1> ### [`v5.0.0`](https://github.com/actions/cache/releases/tag/v5.0.0) [Compare Source](actions/cache@v5...v5) > \[!IMPORTANT] > **`actions/cache@v5` runs on the Node.js 24 runtime and requires a minimum Actions Runner version of `2.327.1`.** > > If you are using self-hosted runners, ensure they are updated before upgrading. *** #### What's Changed - Upgrade to use node24 by [@salmanmkc](https://github.com/salmanmkc) in [#1630](actions/cache#1630) - Prepare v5.0.0 release by [@salmanmkc](https://github.com/salmanmkc) in [#1684](actions/cache#1684) **Full Changelog**: <actions/cache@v4.3.0...v5.0.0> ### [`v5`](actions/cache@v4.3.0...v5) [Compare Source](actions/cache@v4.3.0...v5) ### [`v4.3.0`](https://github.com/actions/cache/releases/tag/v4.3.0) [Compare Source](actions/cache@v4.2.4...v4.3.0) #### What's Changed - Add note on runner versions by [@GhadimiR](https://github.com/GhadimiR) in [#1642](actions/cache#1642) - Prepare `v4.3.0` release by [@Link-](https://github.com/Link-) in [#1655](actions/cache#1655) #### New Contributors - [@GhadimiR](https://github.com/GhadimiR) made their first contribution in [#1642](actions/cache#1642) **Full Changelog**: <actions/cache@v4...v4.3.0> ### [`v4.2.4`](https://github.com/actions/cache/releases/tag/v4.2.4) [Compare Source](actions/cache@v4.2.3...v4.2.4) #### What's Changed - Update README.md by [@nebuk89](https://github.com/nebuk89) in [#1620](actions/cache#1620) - Upgrade `@actions/cache` to `4.0.5` and move `@protobuf-ts/plugin` to dev depdencies by [@Link-](https://github.com/Link-) in [#1634](actions/cache#1634) - Prepare release `4.2.4` by [@Link-](https://github.com/Link-) in [#1636](actions/cache#1636) #### New Contributors - [@nebuk89](https://github.com/nebuk89) made their first contribution in [#1620](actions/cache#1620) **Full Changelog**: <actions/cache@v4...v4.2.4> ### [`v4.2.3`](https://github.com/actions/cache/releases/tag/v4.2.3) [Compare Source](actions/cache@v4.2.2...v4.2.3) #### What's Changed - Update to use [@actions/cache](https://github.com/actions/cache) 4.0.3 package & prepare for new release by [@salmanmkc](https://github.com/salmanmkc) in [#1577](actions/cache#1577) (SAS tokens for cache entries are now masked in debug logs) #### New Contributors - [@salmanmkc](https://github.com/salmanmkc) made their first contribution in [#1577](actions/cache#1577) **Full Changelog**: <actions/cache@v4.2.2...v4.2.3> ### [`v4.2.2`](https://github.com/actions/cache/releases/tag/v4.2.2) [Compare Source](actions/cache@v4.2.1...v4.2.2) #### What's Changed > \[!IMPORTANT] > As a reminder, there were important backend changes to release v4.2.0, see [those release notes](https://github.com/actions/cache/releases/tag/v4.2.0) and [the announcement](actions/cache#1510) for more details. - Bump [@actions/cache](https://github.com/actions/cache) to v4.0.2 by [@robherley](https://github.com/robherley) in [#1560](actions/cache#1560) **Full Changelog**: <actions/cache@v4.2.1...v4.2.2> ### [`v4.2.1`](https://github.com/actions/cache/releases/tag/v4.2.1) [Compare Source](actions/cache@v4.2.0...v4.2.1) #### What's Changed > \[!IMPORTANT] > As a reminder, there were important backend changes to release v4.2.0, see [those release notes](https://github.com/actions/cache/releases/tag/v4.2.0) and [the announcement](actions/cache#1510) for more details. - docs: GitHub is spelled incorrectly in caching-strategies.md by [@janco-absa](https://github.com/janco-absa) in [#1526](actions/cache#1526) - docs: Make the "always save prime numbers" example more clear by [@Tobbe](https://github.com/Tobbe) in [#1525](actions/cache#1525) - Update force deletion docs due a recent deprecation by [@sebbalex](https://github.com/sebbalex) in [#1500](actions/cache#1500) - Bump [@actions/cache](https://github.com/actions/cache) to v4.0.1 by [@robherley](https://github.com/robherley) in [#1554](actions/cache#1554) #### New Contributors - [@janco-absa](https://github.com/janco-absa) made their first contribution in [#1526](actions/cache#1526) - [@Tobbe](https://github.com/Tobbe) made their first contribution in [#1525](actions/cache#1525) - [@sebbalex](https://github.com/sebbalex) made their first contribution in [#1500](actions/cache#1500) **Full Changelog**: <actions/cache@v4.2.0...v4.2.1> ### [`v4.2.0`](https://github.com/actions/cache/releases/tag/v4.2.0) [Compare Source](actions/cache@v4.1.2...v4.2.0) #### ⚠️ Important Changes The cache backend service has been rewritten from the ground up for improved performance and reliability. [actions/cache](https://github.com/actions/cache) now integrates with the new cache service (v2) APIs. The new service will gradually roll out as of **February 1st, 2025**. The legacy service will also be sunset on the same date. Changes in these release are **fully backward compatible**. **We are deprecating some versions of this action**. We recommend upgrading to version `v4` or `v3` as soon as possible before **February 1st, 2025.** (Upgrade instructions below). If you are using pinned SHAs, please use the SHAs of versions `v4.2.0` or `v3.4.0` If you do not upgrade, all workflow runs using any of the deprecated [actions/cache](https://github.com/actions/cache) will fail. Upgrading to the recommended versions will not break your workflows. Read more about the change & access the migration guide: [reference to the announcement](actions/cache#1510). ##### Minor changes Minor and patch version updates for these dependencies: - [@actions/core](https://github.com/actions/core): `1.11.1` - [@actions/io](https://github.com/actions/io): `1.1.3` - [@vercel/ncc](https://github.com/vercel/ncc): `0.38.3` **Full Changelog**: <actions/cache@v4.1.2...v4.2.0> ### [`v4.1.2`](https://github.com/actions/cache/releases/tag/v4.1.2) [Compare Source](actions/cache@v4.1.1...v4.1.2) #### What's Changed - Add Bun example by [@idleberg](https://github.com/idleberg) in [#1456](actions/cache#1456) - Revise `isGhes` logic by [@jww3](https://github.com/jww3) in [#1474](actions/cache#1474) - Bump braces from 3.0.2 to 3.0.3 by [@dependabot](https://github.com/dependabot) in [#1475](actions/cache#1475) - Add dependabot.yml to enable automatic dependency upgrades by [@Link-](https://github.com/Link-) in [#1476](actions/cache#1476) - Bump actions/checkout from 3 to 4 by [@dependabot](https://github.com/dependabot) in [#1478](actions/cache#1478) - Bump actions/stale from 3 to 9 by [@dependabot](https://github.com/dependabot) in [#1479](actions/cache#1479) - Bump github/codeql-action from 2 to 3 by [@dependabot](https://github.com/dependabot) in [#1483](actions/cache#1483) - Bump actions/setup-node from 3 to 4 by [@dependabot](https://github.com/dependabot) in [#1481](actions/cache#1481) - Prepare `4.1.2` release by [@Link-](https://github.com/Link-) in [#1477](actions/cache#1477) #### New Contributors - [@idleberg](https://github.com/idleberg) made their first contribution in [#1456](actions/cache#1456) - [@jww3](https://github.com/jww3) made their first contribution in [#1474](actions/cache#1474) - [@Link-](https://github.com/Link-) made their first contribution in [#1476](actions/cache#1476) **Full Changelog**: <actions/cache@v4.1.1...v4.1.2> ### [`v4.1.1`](https://github.com/actions/cache/releases/tag/v4.1.1) [Compare Source](actions/cache@v4.1.0...v4.1.1) #### What's Changed - Restore original behavior of `cache-hit` output by [@joshmgross](https://github.com/joshmgross) in [#1467](actions/cache#1467) **Full Changelog**: <actions/cache@v4.1.0...v4.1.1> ### [`v4.1.0`](https://github.com/actions/cache/releases/tag/v4.1.0) [Compare Source](actions/cache@v4.0.2...v4.1.0) #### What's Changed - Fix cache-hit output when cache missed by [@fchimpan](https://github.com/fchimpan) in [#1404](actions/cache#1404) - Deprecate `save-always` input by [@joshmgross](https://github.com/joshmgross) in [#1452](actions/cache#1452) #### New Contributors - [@ottlinger](https://github.com/ottlinger) made their first contribution in [#1437](actions/cache#1437) - [@Olegt0rr](https://github.com/Olegt0rr) made their first contribution in [#1377](actions/cache#1377) - [@fchimpan](https://github.com/fchimpan) made their first contribution in [#1404](actions/cache#1404) - [@x612skm](https://github.com/x612skm) made their first contribution in [#1434](actions/cache#1434) - [@todgru](https://github.com/todgru) made their first contribution in [#1311](actions/cache#1311) - [@Jcambass](https://github.com/Jcambass) made their first contribution in [#1463](actions/cache#1463) - [@mackey0225](https://github.com/mackey0225) made their first contribution in [#1462](actions/cache#1462) - [@quatquatt](https://github.com/quatquatt) made their first contribution in [#1445](actions/cache#1445) **Full Changelog**: <actions/cache@v4.0.2...v4.1.0> ### [`v4.0.2`](https://github.com/actions/cache/releases/tag/v4.0.2) [Compare Source](actions/cache@v4.0.1...v4.0.2) #### What's Changed - Fix `fail-on-cache-miss` not working by [@cdce8p](https://github.com/cdce8p) in [#1327](actions/cache#1327) **Full Changelog**: <actions/cache@v4.0.1...v4.0.2> ### [`v4.0.1`](https://github.com/actions/cache/releases/tag/v4.0.1) [Compare Source](actions/cache@v4...v4.0.1) #### What's Changed - Update README.md by [@yacaovsnc](https://github.com/yacaovsnc) in [#1304](actions/cache#1304) - Update examples by [@yacaovsnc](https://github.com/yacaovsnc) in [#1305](actions/cache#1305) - Update actions/cache publish flow by [@bethanyj28](https://github.com/bethanyj28) in [#1340](actions/cache#1340) - Update [@actions/cache](https://github.com/actions/cache) by [@bethanyj28](https://github.com/bethanyj28) in [#1341](actions/cache#1341) #### New Contributors - [@yacaovsnc](https://github.com/yacaovsnc) made their first contribution in [#1304](actions/cache#1304) **Full Changelog**: <actions/cache@v4...v4.0.1> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.lx.e6a.app/tools/cookie-py/pulls/86

x612skm requested a review from a team as a code owner July 18, 2024 17:07

x612skm mentioned this pull request Jul 18, 2024

Incorrect documentation for restore-keys #1173

Closed

webknjaz reviewed Jul 18, 2024

View reviewed changes

Comment thread README.md Outdated

x612skm changed the title ~~Fix description for restore-keys at Readme #1173~~ Fix description for restore-keys at Readme Jul 19, 2024

x612skm changed the title ~~Fix description for restore-keys at Readme~~ Clarify that the restore-keys input is a string in the docs Jul 19, 2024

x612skm requested a review from webknjaz July 19, 2024 11:06

webknjaz approved these changes Jul 19, 2024

View reviewed changes

joshmgross approved these changes Jul 31, 2024

View reviewed changes

joshmgross enabled auto-merge (squash) July 31, 2024 16:53

joshmgross disabled auto-merge July 31, 2024 16:54

joshmgross reviewed Jul 31, 2024

View reviewed changes

x612skm added 3 commits August 6, 2024 16:53

Fix Description for restore-keys at Readme

2b41466

As previously the restore-keys were defined as an ordered lists which is wrong as per the issue description where the actual format is a multi-line string with one key per line.

Change restore-keys description at cache/restore/action.yml and cache…

13f54a0

…/action.yml

x612skm force-pushed the 1173-readme-fix branch from 2ba2e98 to 13f54a0 Compare August 6, 2024 11:24

joshmgross approved these changes Aug 6, 2024

View reviewed changes

joshmgross enabled auto-merge (squash) August 6, 2024 14:26

joshmgross merged commit 57b8e40 into actions:main Aug 6, 2024

prolic mentioned this pull request Oct 7, 2024

Bump actions/cache from 4.0.2 to 4.1.0 futrnostr/futr#29

Merged

Boss-1s mentioned this pull request Oct 30, 2024

Bump actions/cache from 4.0.2 to 4.1.2 in /.github/workflows Boss-1s/scratchattach#13

Closed

davdhacs mentioned this pull request Mar 2, 2026

chore(ci): use commit SHA for go-build cache key stackrox/stackrox#19173

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clarify that the `restore-keys` input is a string in the docs #1434

Clarify that the `restore-keys` input is a string in the docs #1434
joshmgross merged 3 commits into
actions:mainfrom
x612skm:1173-readme-fix

x612skm commented Jul 18, 2024 •

edited

Loading

Uh oh!

Uh oh!

x612skm commented Jul 19, 2024

Uh oh!

joshmgross Jul 31, 2024

Uh oh!

x612skm Aug 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	restore-keys:
	description: 'An ordered list of keys to use for restoring stale cache if no cache hit occurred for key. Note `cache-hit` returns false in this case.'
	required: false

Conversation

x612skm commented Jul 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

x612skm commented Jul 19, 2024

Uh oh!

joshmgross Jul 31, 2024

Choose a reason for hiding this comment

Uh oh!

x612skm Aug 6, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

x612skm commented Jul 18, 2024 •

edited

Loading