Skip to content

Improve definition of "disabled element" #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 24, 2020
Merged

Conversation

Jym77
Copy link
Collaborator

@Jym77 Jym77 commented Nov 12, 2020

The definition was mimicking https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#concept-fe-disabled rather than the more generic https://html.spec.whatwg.org/multipage/semantics-other.html#concept-element-disabled
As far as I follow, this resulted in option elements never being disabled in our sense (well or indirectly via the aria-disabled attribute) and therefore, labels of <option disabled> where applicable for the colour contrast rule.

This is changing the def to the more generic one, using the CSS selector directly (so it also applies to non-HTML elements).
Additionally, the assumption in that definition is copied in the rule with indication of the consequences if it does not hold.

(noticed the issue while working on #1455)

Closes issue(s):

  • N/A

Need for Final Call:
This will require a 1 week Final Call (indirectly changing Applicability of a rule)


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Final Call period. In case of disagreement, the longer period wins.

@Jym77 Jym77 added Rule Update Use this label for an existing rule that is being updated Definition reviewers wanted labels Nov 12, 2020
@Jym77 Jym77 self-assigned this Nov 12, 2020
Copy link
Contributor

@kasperisager kasperisager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small editorial suggestion, looks good otherwise!

Co-authored-by: Kasper Isager <kasperisager@gmail.com>
@Jym77 Jym77 dismissed WilcoFiers’s stale review November 16, 2020 10:57

Good catches. Corrected.

@Jym77 Jym77 requested a review from WilcoFiers November 16, 2020 10:57
@Jym77
Copy link
Collaborator Author

Jym77 commented Nov 17, 2020

Final Call ends on November 24.

@Jym77 Jym77 added Review Call 1 week Call for review for small changes and removed reviewers wanted labels Nov 17, 2020
@Jym77
Copy link
Collaborator Author

Jym77 commented Nov 24, 2020

Final Call has ended. Merging.

@Jym77 Jym77 merged commit b45da01 into develop Nov 24, 2020
@Jym77 Jym77 deleted the improve-disabled-definition branch November 24, 2020 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Definition Review Call 1 week Call for review for small changes Rule Update Use this label for an existing rule that is being updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants