fix(server/players): sort players by playerId

Author: antond15

fxmanifest.lua

@@ -5,7 +5,7 @@ use_experimental_fxv2_oal 'yes'
 
 name 'ac_scoreboard'
 author 'AC Scripts'
-version '2.2.0'
+version '2.2.1'
 description 'A framework-standalone scoreboard UI for FiveM.'
 repository 'https://github.com/acscripts/ac_scoreboard'
 

modules/server/sections/players.lua

@@ -2,18 +2,17 @@ local Players = {}
 
 CreateThread(function()
     for _, playerId in ipairs(GetPlayers()) do
-        Players[playerId] = GetPlayerName(playerId)
+        Players[tonumber(playerId)] = GetPlayerName(playerId)
     end
 end)
 
 
 AddEventHandler('playerJoining', function()
-    local playerId = tostring(source)
-    Players[playerId] = GetPlayerName(playerId)
+    Players[source] = GetPlayerName(source)
 end)
 
 AddEventHandler('playerDropped', function()
-    Players[tostring(source)] = nil
+    Players[source] = nil
 end)
 
 

web/src/components/footer.svelte

@@ -19,6 +19,8 @@
     copied: 'mdi:clipboard-check',
   };
 
+  // preload icons to prevent possible "flash" of empty icon space before it loads
+  // since it's visible only on hover, it's quite noticeable
   loadIcons([copyIcons.copy, copyIcons.copied]);
 </script>