feat: add updatevkey task
#1199
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ihor Farion <ihor@umaproject.org>
Signed-off-by: Ihor Farion <ihor@umaproject.org>
grasphoper
requested review from
bmzig,
mrice32,
nicholaspai and
pxrl
as code owners
fusmanii
reviewed
Nov 28, 2025
Contributor
fusmanii
left a comment
fusmanii
left a comment
There was a problem hiding this comment.
Looks good, just one comment on using deployed-addresses.json instead of deployments.json
tasks/updatevkey.ts
Outdated
| import { task, types } from "hardhat/config"; | ||
| import type { HardhatRuntimeEnvironment } from "hardhat/types"; | ||
| import { ethers } from "ethers"; | ||
| import deploymentsJson from "../deployments/deployments.json"; |
Contributor
There was a problem hiding this comment.
Suggested change
| import deploymentsJson from "../deployments/deployments.json"; | |
| import deploymentsJson from "../broadcast/deployed-addresses.json"; |
Contributor
Author
There was a problem hiding this comment.
Oh duh, you're right. Addressed here f713555
Signed-off-by: Ihor Farion <ihor@umaproject.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A task that can generate data to pass into
multicallon the HubPool to updatevkeyof the Universal chains (that are using ZK-messaging)