fix(svm): L-09 close instruction_params account after execute_relayer_refund_leaf (#840)

* fix(svm): L-09 close instruction_params account after execute_relayer_refund_leaf

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>

* test: instruction params account is closed

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>

---------

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>

Author: Reinis-FRP

programs/svm-spoke/src/instructions/bundle.rs

@@ -18,7 +18,7 @@ pub struct ExecuteRelayerRefundLeaf<'info> {
     #[account(mut)]
     pub signer: Signer<'info>,
 
-    #[account(seeds = [b"instruction_params", signer.key().as_ref()], bump)]
+    #[account(mut, seeds = [b"instruction_params", signer.key().as_ref()], bump, close = signer)]
     pub instruction_params: Account<'info, ExecuteRelayerRefundLeafParams>, // Contains all leaf & proof information.
 
     #[account(seeds = [b"state", state.seed.to_le_bytes().as_ref()], bump)]

test/svm/SvmSpoke.Bundle.ts

@@ -241,13 +241,23 @@ describe("svm_spoke.bundle", () => {
       program: program.programId,
     };
     const proofAsNumbers = proof.map((p) => Array.from(p));
-    await loadExecuteRelayerRefundLeafParams(program, owner, stateAccountData.rootBundleId, leaf, proofAsNumbers);
+    const instructionParams = await loadExecuteRelayerRefundLeafParams(
+      program,
+      owner,
+      stateAccountData.rootBundleId,
+      leaf,
+      proofAsNumbers
+    );
     const tx = await program.methods
       .executeRelayerRefundLeaf()
       .accounts(executeRelayerRefundLeafAccounts)
       .remainingAccounts(remainingAccounts)
       .rpc();
 
+    // Verify the instruction params account has been automatically closed.
+    const instructionParamsInfo = await program.provider.connection.getAccountInfo(instructionParams);
+    assert.isNull(instructionParamsInfo, "Instruction params account should be closed");
+
     // Verify the ExecutedRelayerRefundRoot event
     let events = await readEventsUntilFound(connection, tx, [program]);
     let event = events.find((event) => event.name === "executedRelayerRefundRoot")?.data;