[Webpack] Compilation error fix #8293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laemtl
force-pushed
the
webpack-post-install-fix
branch
from
301d729 to
c6f175e
Compare
maltheism
approved these changes
Dec 20, 2022
driusan
approved these changes
Dec 20, 2022
zaliqarosli
added
the
Passed manual tests
zaliqarosli
approved these changes
Dec 20, 2022
laemtl
added
the
State: Needs work
Collaborator
|
@laemtl was about to merge this then noticed the needs work tag.. what's needed on this? |
laemtl
force-pushed
the
webpack-post-install-fix
branch
from
c6f175e to
8bed822
Compare
laemtl
removed
the
State: Needs work
laemtl
force-pushed
the
webpack-post-install-fix
branch
from
8bed822 to
645b5e3
Compare
zaliqarosli
requested changes
Dec 20, 2022
Contributor
zaliqarosli
left a comment
zaliqarosli
left a comment
There was a problem hiding this comment.
ERROR in
/var/www/loris/npm-postinstall.js
114:10 error Parsing error: The only valid numeric escape in strict mode is '\0'. (114:10)
✖ 1 problem (1 error, 0 warnings)
Contributor
Author
The same fix was needed for npm-postinstall.js as well. It's done. |
laemtl
force-pushed
the
webpack-post-install-fix
branch
from
645b5e3 to
59524cb
Compare
Contributor
Author
Thanks and fixed! |
zaliqarosli
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address an issue that prevents webpack and the post-install script to run when patch SQL/New_patches/2022-12-05-AddVizConfig.sql is not applied.
Now the errors are caught and a warning is printed on the screen.