[dashboard][Study Progression] Add tooltip visualising of Total in line chart #8123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
racostas
requested changes
Jul 24, 2022
Contributor
racostas
left a comment
racostas
left a comment
There was a problem hiding this comment.
Minor change. Let's please put the CSS modifications inside the module itself.
/modules/statistics/css/recruitment.css
racostas
reviewed
Aug 2, 2022
racostas
approved these changes
Aug 2, 2022
Contributor
racostas
left a comment
racostas
left a comment
There was a problem hiding this comment.
LGTM. Two extra lines that could be removed from the .css file. Not sure why the automated test continue failing, but doesn't seem to be related to this PR.
Co-authored-by: racostas <37309344+racostas@users.noreply.github.com>
Co-authored-by: racostas <37309344+racostas@users.noreply.github.com>
racostas
added
Event: GSOC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Testing instructions (if applicable)
Link(s) to related issue(s)
Here's how the changes look:
