Skip to content

[Test] Fix broken build - php-ast #7399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2021
Merged

[Test] Fix broken build - php-ast #7399

merged 1 commit into from
Mar 18, 2021

Conversation

@laemtl
Copy link
Contributor

@laemtl laemtl commented Mar 18, 2021 •
edited
Loading

Fix a build problem under php7.3 on v23.0 (see #7397 (comment) for reference).

@laemtl laemtl mentioned this pull request Mar 18, 2021
Merged
@laemtl laemtl force-pushed the 2021-03-18-ast-version-fix branch from 5263643 to e013d19 Compare March 18, 2021 06:23
@laemtl laemtl changed the title [Test] Fix php-ast version [Test] Fix broken build - php-ast Mar 18, 2021
@laemtl laemtl added Critical to release PR or issue is key for the release to which it has been assigned State: Blocking PR should be prioritized because it is blocking the progress of another task labels Mar 18, 2021
kongtiaowang
kongtiaowang approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@kongtiaowang kongtiaowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christinerogers
Copy link
Contributor

christinerogers commented Mar 18, 2021

@driusan could you please review / merge ?

This fix is blocking another bug fix that should go in the next bug fix release (see Laetitia's comment)

@christinerogers christinerogers requested a review from driusan March 18, 2021 13:15
@driusan driusan merged commit 0df4ed8 into aces:23.0-release Mar 18, 2021
@driusan driusan mentioned this pull request Mar 18, 2021
Closed
@ridz1208 ridz1208 added this to the 23.0.3 milestone Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kongtiaowang kongtiaowang kongtiaowang approved these changes

@driusan driusan Awaiting requested review from driusan

Assignees

No one assigned

Labels

Critical to release PR or issue is key for the release to which it has been assigned State: Blocking PR should be prioritized because it is blocking the progress of another task

Projects

None yet

Milestone

23.0.3

Development

Successfully merging this pull request may close these issues.

5 participants

@laemtl @christinerogers @kongtiaowang @driusan @ridz1208