[LINST Instrument][Bugfix] Age at Death is displayed at top page when candidate is still alive

[jesscall]

Brief summary of changes

Bugfix to ensure that age at death is only displayed if the candidate has passed away.
This bug only appears in LINST instrument. Please refer to #7396

Testing instructions (if applicable)

1. Go to a random (LINST) instrument and fill out top page. Click Save.
2. Make sure that you see Candidate Age (Months) displayed if candidate is still alive.
3. Navigate to Candidate Parameters and fill in Date of Death tab.
4. Go to instrument top page, you should now see Candidate Age at Death (Months)

Link(s) to related issue(s)

• Resolves [LINST] Date of Death displayed when candidate is still Alive #7396

[christinerogers]

thanks @jesscall - requesting @laemtl review since i won't be able to test.

[christinerogers]

LGTM

[laemtl]

Thank you Jessica! PHPCS needs a small fix.

-- edit
The problem needs to be fixed on the test suite side:
ERROR: The php-ast extension must be loaded in order for Phan to work. Either install and enable php-ast, or invoke Phan with the CLI option --allow-polyfill-parser (which is noticeably slower)

This was solved recently in PR #7369. Maybe a rebase will fix the problem?

[jesscall]

@laemtl I'm pretty sure i fetched before making this PR, but i'll try a rebase in case

Edit:
Just checked and I have the recent changes from #7396
@kongtiaowang any idea why this is still failing test suite?

[laemtl]

From the build log I can see that installing php-ast remove php-ast for php 7.3:

sudo apt-get install php-ast
  shell: /usr/bin/bash -e {0}
Reading package lists...
Building dependency tree...
Reading state information...
The following additional packages will be installed:
  php7.4-cli php7.4-common php7.4-json php7.4-opcache php7.4-phpdbg
  php7.4-readline
Suggested packages:
  php-pear
The following packages will be REMOVED:
  php7.3-ast
The following NEW packages will be installed:
  php-ast php7.4-cli php7.4-common php7.4-json php7.4-opcache php7.4-phpdbg
  php7.4-readline
0 upgraded, 7 newly installed, 1 to remove and 3 not upgraded.

Can sudo apt-get install php7.3-ast and sudo apt-get install php7.4-ast in place of sudo apt-get install php-ast help to solve the issue?

[laemtl]

Build issue fixed with #7399

[jesscall]

@laemtl Thanks for the fix! Rebased and ready for review :)

[christinerogers]

@driusan this bugfix for LINST instruments is ready for your review - thanks.

I think this should go in our next bug fix release -- if it needs to be on a different branch, don't hesitate.

[christinerogers]

Thanks everyone @jesscall @laemtl @driusan for the quick work on this. 🎉