Skip to content

Conversation

@kongtiaowang
Copy link
Contributor

@kongtiaowang kongtiaowang commented Mar 15, 2021

Brief summary of changes

23.0-release, php-ast can't install on the PHP 7.3 in the git action.
So, add "--allow-polyfill-parser" to ignore the "php-ast" in 23.0-release

Link(s) to related issue(s)

ERROR: The php-ast extension must be loaded in order for Phan to work.
#7386

@driusan
Copy link
Collaborator

driusan commented Mar 16, 2021

Why can't php-ast be installed? There's no reason it shouldn't be installable..

@kongtiaowang
Copy link
Contributor Author

@driusan in this PR https://github.com/aces/Loris/pull/7386/checks?check_run_id=2131039416.
php-ast works on php 7.4. it didn't work on php 7.3 last week for no reason.

@driusan
Copy link
Collaborator

driusan commented Mar 18, 2021

From my understanding this should be fixed correctly by #7399 without reverting to the polyfill parser.

@driusan driusan closed this Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants