Skip to content

Data integrity #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Apr 10, 2013
Merged

Data integrity #70

merged 36 commits into from
Apr 10, 2013

Conversation

@mohadesz
Copy link
Contributor

@mohadesz mohadesz commented Oct 5, 2012

This branch contains the data_integrity module. The following changes/customization need to be done in order to use this module

  1. The data_integrity_flag module tab needs to be added (as included in the docs/config.xml)
  2. The data_integrity_flag Table ( as well as the appropriate permission) needs to be created using the SQL/0000-00-00-schema.sql for new projects and SQL/2012-10-05-data_integrity_table_creation.sql for existing projects.

driusan
driusan reviewed Dec 17, 2012
View reviewed changes
SQL/0000-00-00-schema.sql Outdated
Copy link
Collaborator

@driusan driusan Dec 17, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be UTF-8, not latin1

@mohadesz
Copy link
Contributor Author

mohadesz commented Dec 17, 2012

Fixed all the above issues. Also ran the javascript code through JsLint
http://jslint.com/

And fixed allot of coding issues.

driusan
driusan reviewed Dec 18, 2012
View reviewed changes
php/libraries/NDB_Form_data_integrity_flag.class.inc Outdated
Copy link
Collaborator

@driusan driusan Dec 18, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be $DB = Database::singleton()?

@mohadesz
Copy link
Contributor Author

mohadesz commented Dec 19, 2012

All the above issues are now fixed. The branch is now ready to be merged

mohadesz added 21 commits April 9, 2013 16:01
@mohadesz
Changed the charset
3f382cc
@mohadesz
Removed the extra tab
a8ac6c9
@mohadesz
Fixed indentation, modified the $db object and fixed the logic of con…
38a58ce 
…ditional stmnt
@mohadesz
Fixed indentation
bf85a87
@mohadesz
Used new option and added the function definition
8366eb5
@mohadesz
Changed vlable to vlabel
3fb6f54
@mohadesz
removed the {php} functions
b7131ce
@mohadesz
Added two new buttons
4c3dc62
@mohadesz
Revert "removed the {php} functions"
1b20dbc 
This reverts commit 7a5087620c89bdc0e8fc61601581a2da96721950.
@mohadesz
1) add the all-instruments to the dropdown, 2) form reload when visit…
c7ade76 
…_label is changed
@mohadesz
a) modified AddWhere() and b) fixed the getTestNameusingMappedName issue
e8c43c3
@mohadesz
Have merged teh file
9ad2d61
@mohadesz
1) cosmetic changes--removed unnecessary codes, 2) added a new button
0bccd76
@mohadesz
1) Cosmetic changes 2) filter is executed when teh visit_lable is cha…
90c2501 
…nged
@mohadesz
chnaged onchange function to changeVisitLabels
1f5e795
@mohadesz
Add a new column called dataflag_userid
7263455
@mohadesz
set the visit_label_value to null if the value is all visits, and lo…
aa10a7d 
…ad the page when the users is selected
@mohadesz
included the users list in the filter
ccf7fec
@mohadesz
included the users drop down in the template
acba8cb
@mohadesz
Cosmetic changes
aa4d18f
@mohadesz
Includes the some config options in violated_scans_module
e19a04f
@driusan
Copy link
Collaborator

driusan commented Apr 10, 2013

This was approved on Tuesday but had to be re-based. I'm clicking the button now that Zia's done so.

driusan added a commit that referenced this pull request Apr 10, 2013
@driusan
Merge pull request #70 from mohadesz/data_integrity
095c244 
Data integrity
@driusan driusan merged commit 095c244 into aces:master Apr 10, 2013
@driusan driusan added Category: Feature PR or issue that aims to introduce a new feature Language: SQL PR or issue that update SQL code labels Dec 19, 2014
stellarxo pushed a commit to stellarxo/Loris that referenced this pull request May 9, 2016
@driusan
Merge pull request aces#70 from rathisekaran/Project_SubprojLink
fff028e 
adding getValidSubprojects to Candidate class
ZainVirani added a commit to ZainVirani/Loris that referenced this pull request Mar 28, 2018
@ZainVirani
Merge pull request aces#70 from Jkat/cap-dev-instrument-status-contro…
ed93225 
…l-panel-fix

Fixing Instrument Status Control Panel for JSON instruments
@jftunteng jftunteng added this to the PRE 20.0.0 milestone Jan 7, 2020
jeffersoncasimir pushed a commit to jeffersoncasimir/Loris that referenced this pull request Feb 24, 2023
@jesscall
Merge pull request aces#70 from jesscall/2022_02_01_HED_DB_Architecture
b3843ab 
DB Structure for HED Tags + supporting changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Category: Feature PR or issue that aims to introduce a new feature Language: SQL PR or issue that update SQL code

Projects

None yet

Milestone

PRE 20.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mohadesz @driusan @jftunteng