Fix PhanUndeclaredMethod in tests directory (#7241)

This fixes all of the "PhanUndeclaredMethod" class errors in the test directory. These are mostly caused by phan not knowing that mock objects have the methods of the class being mocked, and it needs to be specifically told so with a phan type assertion.

Calling methods that don't exist is a bad idea. We should unignore this error type, but first the errors need to be fixed. This PR starts with a large number of false positives caused by mock objects..

Author: driusan

test/unittests/Database_Test.php

@@ -187,6 +187,8 @@ function testUpdateEscapesHTML()
 
         $stub->_PDO->expects($this->once())
             ->method("prepare")->will($this->returnValue($stmt));
+
+        '@phan-var \Database $stub';
         $stub->update("test", ['field' => '<b>Hello</b>'], []);
 
     }
@@ -213,6 +215,8 @@ function testUnsafeUpdateDoesntEscapeHTML()
 
         $stub->_PDO->expects($this->once())
             ->method("prepare")->will($this->returnValue($stmt));
+
+        '@phan-var \Database $stub';
         $stub->unsafeupdate("test", ['field' => '<b>Hello</b>'], []);
 
     }
@@ -238,6 +242,8 @@ function testInsertEscapesHTML()
 
         $stub->_PDO->expects($this->once())
             ->method("prepare")->will($this->returnValue($stmt));
+
+        '@phan-var \Database $stub';
         $stub->insert("test", ['field' => '<b>Hello</b>'], []);
 
     }
@@ -264,6 +270,8 @@ function testUnsafeInsertDoesntEscapeHTML()
 
         $stub->_PDO->expects($this->once())->method("prepare")
             ->will($this->returnValue($stmt));
+
+        '@phan-var \Database $stub';
         $stub->unsafeinsert("test", ['field' => '<b>Hello</b>'], []);
 
     }
@@ -797,6 +805,8 @@ function testInsertOnDuplicateUpdateEscapesHTML()
 
         $stub->_PDO->expects($this->once())
             ->method("prepare")->will($this->returnValue($stmt));
+
+        '@phan-var \Database $stub';
         $stub->insertOnDuplicateUpdate(
             "test",
             ['field' => '<b>Hello</b>'],
@@ -828,6 +838,8 @@ function testUnsafeInsertOnDuplicateUpdateDoesntEscapeHTML()
 
         $stub->_PDO->expects($this->once())
             ->method("prepare")->will($this->returnValue($stmt));
+
+        '@phan-var \Database $stub';
         $stub->unsafeInsertOnDuplicateUpdate(
             "test",
             ['field' => '<b>Hello</b>'],
@@ -885,6 +897,8 @@ function testRun()
 
         $stub->_PDO->expects($this->once())
             ->method("exec")->with($this->equalTo("SHOW TABLES"));
+
+        '@phan-var \Database $stub';
         $stub->run("SHOW TABLES");
     }
 
@@ -907,6 +921,8 @@ function testPrepare()
             ->method("prepare")
             ->with($this->equalTo("SHOW TABLES"))
             ->willReturn(new PDOStatement());
+
+        '@phan-var \Database $stub';
         $stub->prepare("SHOW TABLES");
     }
 
@@ -1017,13 +1033,17 @@ function testPselectCallsFunctions()
         $stub           = $this->getMockBuilder('FakeDatabase')
             ->onlyMethods($this->_getAllMethodsExcept(['pselect']))->getMock();
 
+        '@phan-var \Database $stub';
         $stmt   = $stub->prepare("SHOW TABLES");
         $params = ['test' => 'test'];
 
+        '@phan-var \PHPUnit\Framework\MockObject\MockObject $stub';
         $stub->expects($this->once())
             ->method("prepare")->with($this->equalTo("SHOW TABLES"));
         $stub->expects($this->once())->method("execute")
             ->with($this->equalTo($stmt), $this->equalTo($params), []);
+
+        '@phan-var \Database $stub';
         $stub->pselect("SHOW TABLES", $params);
     }
 
@@ -1080,6 +1100,8 @@ function testPselectRowCallsPrepare()
                 $this->equalTo($query . " LIMIT 2"),
                 $params
             );
+
+        '@phan-var \Database $stub';
         $stub->pselectRow(
             $query,
             $params
@@ -1324,6 +1346,8 @@ function testInsertIgnore()
 
         $stub->expects($this->once())
             ->method("_realinsert")->with($this->equalTo($table), $set, true, true);
+
+        '@phan-var \Database $stub';
         $stub->insertIgnore($table, $set);
     }
 
@@ -1589,6 +1613,8 @@ function testQuote()
         $string = "Co'mpl''ex \"st'\"ring";
         $stub->_PDO->expects($this->once())->method("quote")
             ->willReturn("Complex string");
+
+        '@phan-var \Database $stub';
         $stub->quote($string);
     }
 
@@ -1621,6 +1647,8 @@ function testInTransaction()
 
         $stub->_PDO->expects($this->once())->method("inTransaction")
             ->willReturn(true);
+
+        '@phan-var \Database $stub';
         $stub->inTransaction();
     }
 
@@ -1643,6 +1671,8 @@ function testBeginTransaction()
         $stub->expects($this->once())->method("inTransaction")->willReturn(false);
         $stub->_PDO->expects($this->once())->method("beginTransaction")
             ->willReturn(true);
+
+        '@phan-var \Database $stub';
         $stub->beginTransaction();
     }
 
@@ -1663,6 +1693,8 @@ function testBeginTransactionThrowsException()
 
         $stub->expects($this->once())->method("inTransaction")->willReturn(true);
         $this->expectException("DatabaseException");
+
+        '@phan-var \Database $stub';
         $stub->beginTransaction();
     }
 
@@ -1682,6 +1714,8 @@ function testRollback()
 
         $stub->expects($this->once())->method("inTransaction")->willReturn(true);
         $stub->_PDO->expects($this->once())->method("rollBack")->willReturn(true);
+
+        '@phan-var \Database $stub';
         $stub->rollBack();
     }
 
@@ -1701,6 +1735,8 @@ function testRollbackThrowsException()
 
         $stub->expects($this->once())->method("inTransaction")->willReturn(false);
         $this->expectException("DatabaseException");
+
+        '@phan-var \Database $stub';
         $stub->rollBack();
     }
 
@@ -1720,6 +1756,8 @@ function testCommit()
 
         $stub->expects($this->once())->method("inTransaction")->willReturn(true);
         $stub->_PDO->expects($this->once())->method("commit")->willReturn(true);
+
+        '@phan-var \Database $stub';
         $stub->commit();
     }
 
@@ -1739,6 +1777,8 @@ function testCommitThrowsException()
 
         $stub->expects($this->once())->method("inTransaction")->willReturn(false);
         $this->expectException("DatabaseException");
+
+        '@phan-var \Database $stub';
         $stub->commit();
     }
 
@@ -1755,6 +1795,7 @@ function testIsConnectedNoPDO()
             ->onlyMethods($this->_getAllMethodsExcept(['isConnected']))
             ->getMock();
 
+        '@phan-var \Database $stub';
         $val = $stub->isConnected();
         $this->assertEquals($val, false);
     }
@@ -1772,6 +1813,7 @@ function testIsConnectedWithPDO()
             ->onlyMethods($this->_getAllMethodsExcept(['isConnected']))
             ->getMock();
 
+        '@phan-var \Database $stub';
         $stub->_PDO = $this->getMockBuilder('FakePDO')->getMock();
         $val        = $stub->isConnected();
         $this->assertEquals($val, true);