[document repository] prevent to add same category name under same parent directory (#7255)

Preventing to add same category name under same parent directory. The path to the category must be unique, but different categories can have subcategories with the same name.

Resolves #7232

Author: kongtiaowang

modules/document_repository/jsx/categoryForm.js

@@ -1,5 +1,7 @@
 import PropTypes from 'prop-types';
 import Loader from 'Loader';
+import swal from 'sweetalert2';
+
 /**
  * Document Upload Form
  *
@@ -120,16 +122,28 @@ class DocCategoryForm extends React.Component {
       credentials: 'same-origin',
       body: formObj,
     })
-    .then((resp) => resp.json())
-    .then(()=>{
+    .then((resp) => {
+      if (resp.ok) {
         this.props.refreshPage();
         this.fetchData();
         // refresh the upload page
         this.props.newCategoryState();
         this.setState({
           formData: {}, // reset form data after successful file upload
         });
-        swal('Add Successful!', '', 'success');
+        swal.fire('Category Successfully Added!', '', 'success');
+      } else {
+        resp.json().then((data) => {
+          swal.fire('Could not add category!', data.error, 'error');
+        }).catch((error) => {
+          console.error(error);
+          swal.fire(
+            'Unknown Error!',
+            'Please report the issue or contact your administrator.',
+            'error'
+          );
+        });
+      }
     });
   }
   /**

modules/document_repository/php/uploadcategory.class.inc

@@ -50,15 +50,19 @@ class UploadCategory extends \NDB_Page
     public function handle(ServerRequestInterface $request) : ResponseInterface
     {
         if ($request->getMethod() == "POST") {
-            $this->uploadDocCategory($request);
-            return (new \LORIS\Http\Response())
-                ->withHeader("Content-Type", "text/plain")
-                ->withStatus(200)
-                ->withBody(
-                    new \LORIS\Http\StringStream(
-                        json_encode("uploaded successfully")
-                    )
-                );
+            if ($this->uploadDocCategory($request)) {
+                return (new \LORIS\Http\Response())
+                    ->withHeader("Content-Type", "text/plain")
+                    ->withStatus(200)
+                    ->withBody(
+                        new \LORIS\Http\StringStream(
+                            json_encode("uploaded successfully")
+                        )
+                    );
+            }
+            return new \LORIS\Http\Response\JSON\Conflict(
+                "Duplicate category name under same parent folder."
+            );
         } else {
             return (new \LORIS\Http\Response())
                 ->withHeader("Content-Type", "text/plain")
@@ -71,16 +75,19 @@ class UploadCategory extends \NDB_Page
      *
      * @param ServerRequestInterface $request The incoming PSR7 request
      *
-     * @return void
+     * @return bool
      */
-    function uploadDocCategory($request): void
+    function uploadDocCategory($request): bool
     {
         $DB            = \Database::singleton();
         $req           = $request->getParsedBody();
         $category_name = $req['categoryName']; // required
         $parent_id     = isset($req['parentId']) ? $req['parentId'] : '0';
         $comments      = isset($req['comments']) ? $req['comments'] : null;
-        // todo check duplicate name category
+        //check duplicate name category
+        if ($this->existCategoryName($category_name, $parent_id)) {
+            return false;
+        }
         $DB->insert(
             "document_repository_categories",
             array(
@@ -89,5 +96,28 @@ class UploadCategory extends \NDB_Page
                 "comments"      => $comments,
             )
         );
+        return true;
+    }
+    /**
+     * Check the category name under the same parent folder in the database,
+     * if exists return true
+     *
+     * @param string $categoryName file name
+     * @param int    $parent_id    parent folder id
+     *
+     * @return bool
+     */
+    function existCategoryName(string $categoryName, int $parent_id): bool
+    {
+        $DB            = \NDB_Factory::singleton()->database();
+        $categoryCount =  $DB->pselectOne(
+            "SELECT COUNT(*) FROM document_repository_categories
+             WHERE category_name=:name and parent_id=:id ",
+            array('name' => $categoryName, 'id' => $parent_id)
+        );
+        if ((int)$categoryCount > 0) {
+            return true;
+        }
+        return false;
     }
 }