Skip to content

Commit 91dd6b6

Browse files
committed
It turns out that new candidate was there for a reason
1 parent 69d4ffb commit 91dd6b6

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

php/libraries/NDB_BVL_Instrument.class.inc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ abstract class NDB_BVL_Instrument extends NDB_Page
2323
/**
2424
* The form object for this instrument.
2525
*
26-
* @var LorisForm
26+
* @var ?LorisForm
2727
* @access public
2828
*/
2929
public $form;

test/unittests/NDB_BVL_Instrument_Test.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1787,6 +1787,11 @@ function testToJsonParseSmartyDateTypeNotLorisForm()
17871787
],
17881788
'NoResponse' => true
17891789
];
1790+
1791+
// Exercise the code intended to use QuickForm instead of
1792+
// LorisForm by making this->_instrument->form not a LorisForm.
1793+
$this->_instrument->form = null;
1794+
17901795
$this->assertEquals($result, $this->_instrument->_toJSONParseSmarty($el));
17911796
}
17921797

0 commit comments

Comments
 (0)