[candidate_parameters] Fix candidate_parameters permission problem (#8793)

Remove unnecessary access_profiles permission check that was overriding the module permission checks.

Resolves #8733

Author: sanjay-thiyagarajan

modules/candidate_parameters/php/candidate_parameters.class.inc

@@ -42,17 +42,15 @@ class Candidate_Parameters extends \NDB_Form
     {
         $candidate =& \Candidate::singleton(new CandID($this->identifier));
 
-        // User must either have 'access_all_profiles' permission, or
-        // one of the candidate_parameter permissions AND have the candidate's site.
-        return $user->hasPermission('access_all_profiles') ||
-            ($user->hasAnyPermission(
-                [
-                    'candidate_parameter_view',
-                    'candidate_parameter_edit',
-                ]
-            )
-                && $user->hasCenter($candidate->getCenterID())
-            );
+        /* User must have one of the candidate_parameter permissions
+        AND have the candidate's site. */
+        return ($user->hasAnyPermission(
+            [
+                'candidate_parameter_view',
+                'candidate_parameter_edit',
+            ]
+        ) && $user->hasCenter($candidate->getCenterID())
+        );
     }
 
     /**