Skip to content

Commit

Permalink
[PATCH] sysctl: x25: remove unnecessary insert_at_head from register_…
Browse files Browse the repository at this point in the history
…sysctl_table

There has not been much maintenance on sysctl in years, and as a result is
there is a lot to do to allow future interesting work to happen, and being
ambitious I'm trying to do it all at once :)

The patches in this series fall into several general categories.

- Removal of useless attempts to override the standard sysctls

- Registers of sysctl numbers in sysctl.h so someone else does not use
  the magic number and conflict.

- C99 conversions so it becomes possible to change the layout of
  struct ctl_table without breaking everything.

- Removal of useless claims of module ownership, in the proc dir entries

- Removal of sys_sysctl support where people had used conflicting sysctl
  numbers. Trying to break glibc or other applications by changing the
  ABI is not cool.  9 instances of this in the kernel seems a little
  extreme.

- General enhancements when I got the junk I could see out.

This patch:

Since x25 uses unique binary numbers inserting yourself at the head of the
search list for sysctls so you can override already registered sysctls is
pointless.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
ebiederm authored and Linus Torvalds committed Feb 14, 2007
1 parent aa2e3e4 commit b402f06
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/x25/sysctl_net_x25.c
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ static struct ctl_table x25_root_table[] = {

void __init x25_register_sysctl(void)
{
x25_table_header = register_sysctl_table(x25_root_table, 1);
x25_table_header = register_sysctl_table(x25_root_table, 0);
}

void x25_unregister_sysctl(void)
Expand Down

0 comments on commit b402f06

Please sign in to comment.