Revert "Remove redundant initial of isArray (facebook#21163)"

This reverts commit b130a0f.

Author: sebmarkbage

packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js

@@ -145,8 +145,6 @@ export default {
         componentScope = currentScope;
       }
 
-      const isArray = Array.isArray;
-
       // Next we'll define a few helpers that helps us
       // tell if some values don't have to be declared as deps.
 
@@ -159,7 +157,7 @@ export default {
       //       ^^^ true for this reference
       // False for everything else.
       function isStableKnownHookValue(resolved) {
-        if (!isArray(resolved.defs)) {
+        if (!Array.isArray(resolved.defs)) {
           return false;
         }
         const def = resolved.defs[0];
@@ -228,7 +226,7 @@ export default {
           if (
             id.type === 'ArrayPattern' &&
             id.elements.length === 2 &&
-            isArray(resolved.identifiers)
+            Array.isArray(resolved.identifiers)
           ) {
             // Is second tuple value the same reference we're checking?
             if (id.elements[1] === resolved.identifiers[0]) {
@@ -257,7 +255,7 @@ export default {
         } else if (name === 'useTransition') {
           if (
             id.type === 'ArrayPattern' &&
-            isArray(resolved.identifiers)
+            Array.isArray(resolved.identifiers)
           ) {
             // Is first tuple value the same reference we're checking?
             if (id.elements[0] === resolved.identifiers[0]) {
@@ -272,7 +270,7 @@ export default {
 
       // Some are just functions that don't reference anything dynamic.
       function isFunctionWithoutCapturedValues(resolved) {
-        if (!isArray(resolved.defs)) {
+        if (!Array.isArray(resolved.defs)) {
           return false;
         }
         const def = resolved.defs[0];

packages/jest-react/src/JestReact.js

@@ -8,7 +8,6 @@
 import {REACT_ELEMENT_TYPE, REACT_FRAGMENT_TYPE} from 'shared/ReactSymbols';
 
 import invariant from 'shared/invariant';
-import isArray from 'shared/isArray';
 
 function captureAssertion(fn) {
   // Trick to use a Jest matcher inside another Jest matcher. `fn` contains an
@@ -43,7 +42,7 @@ export function unstable_toMatchRenderedOutput(root, expectedJSX) {
   let actualJSX;
   if (actualJSON === null || typeof actualJSON === 'string') {
     actualJSX = actualJSON;
-  } else if (isArray(actualJSON)) {
+  } else if (Array.isArray(actualJSON)) {
     if (actualJSON.length === 0) {
       actualJSX = null;
     } else if (actualJSON.length === 1) {

packages/react-devtools-shared/src/backend/renderer.js

@@ -105,7 +105,6 @@ import type {
   ElementType,
 } from 'react-devtools-shared/src/types';
 import is from 'shared/objectIs';
-import isArray from 'shared/isArray';
 
 type getDisplayNameForFiberType = (fiber: Fiber) => string | null;
 type getTypeSymbolType = (type: any) => Symbol | number;
@@ -1138,7 +1137,7 @@ export function attach(
       memoizedState.hasOwnProperty('create') &&
       memoizedState.hasOwnProperty('destroy') &&
       memoizedState.hasOwnProperty('deps') &&
-      (memoizedState.deps === null || isArray(memoizedState.deps)) &&
+      (memoizedState.deps === null || Array.isArray(memoizedState.deps)) &&
       memoizedState.hasOwnProperty('next')
     );
   }

packages/react-devtools-shared/src/backend/utils.js

@@ -9,7 +9,6 @@
 
 import {copy} from 'clipboard-js';
 import {dehydrate} from '../hydration';
-import isArray from 'shared/isArray';
 
 import type {DehydratedData} from 'react-devtools-shared/src/devtools/views/Components/types';
 
@@ -62,9 +61,9 @@ export function copyWithDelete(
   index: number = 0,
 ): Object | Array<any> {
   const key = path[index];
-  const updated = isArray(obj) ? obj.slice() : {...obj};
+  const updated = Array.isArray(obj) ? obj.slice() : {...obj};
   if (index + 1 === path.length) {
-    if (isArray(updated)) {
+    if (Array.isArray(updated)) {
       updated.splice(((key: any): number), 1);
     } else {
       delete updated[key];
@@ -85,12 +84,12 @@ export function copyWithRename(
   index: number = 0,
 ): Object | Array<any> {
   const oldKey = oldPath[index];
-  const updated = isArray(obj) ? obj.slice() : {...obj};
+  const updated = Array.isArray(obj) ? obj.slice() : {...obj};
   if (index + 1 === oldPath.length) {
     const newKey = newPath[index];
     // $FlowFixMe number or string is fine here
     updated[newKey] = updated[oldKey];
-    if (isArray(updated)) {
+    if (Array.isArray(updated)) {
       updated.splice(((oldKey: any): number), 1);
     } else {
       delete updated[oldKey];
@@ -112,7 +111,7 @@ export function copyWithSet(
     return value;
   }
   const key = path[index];
-  const updated = isArray(obj) ? obj.slice() : {...obj};
+  const updated = Array.isArray(obj) ? obj.slice() : {...obj};
   // $FlowFixMe number or string is fine here
   updated[key] = copyWithSet(obj[key], path, value, index + 1);
   return updated;

packages/react-dom/src/client/ReactDOMSelect.js

@@ -12,7 +12,6 @@ import {getCurrentFiberOwnerNameInDevOrNull} from 'react-reconciler/src/ReactCur
 
 import {checkControlledValueProps} from '../shared/ReactControlledValuePropTypes';
 import {getToStringValue, toString} from './ToStringValue';
-import isArray from 'shared/isArray';
 
 let didWarnValueDefaultValue;
 
@@ -46,15 +45,15 @@ function checkSelectPropTypes(props) {
       if (props[propName] == null) {
         continue;
       }
-      const propNameIsArray = isArray(props[propName]);
-      if (props.multiple && !propNameIsArray) {
+      const isArray = Array.isArray(props[propName]);
+      if (props.multiple && !isArray) {
         console.error(
           'The `%s` prop supplied to <select> must be an array if ' +
             '`multiple` is true.%s',
           propName,
           getDeclarationErrorAddendum(),
         );
-      } else if (!props.multiple && propNameIsArray) {
+      } else if (!props.multiple && isArray) {
         console.error(
           'The `%s` prop supplied to <select> must be a scalar ' +
             'value if `multiple` is false.%s',

packages/react-dom/src/client/ReactDOMTextarea.js

@@ -8,12 +8,12 @@
  */
 
 import invariant from 'shared/invariant';
-import isArray from 'shared/isArray';
 
 import {checkControlledValueProps} from '../shared/ReactControlledValuePropTypes';
 import {getCurrentFiberOwnerNameInDevOrNull} from 'react-reconciler/src/ReactCurrentFiber';
 import {getToStringValue, toString} from './ToStringValue';
 import type {ToStringValue} from './ToStringValue';
+
 import {disableTextareaChildren} from 'shared/ReactFeatureFlags';
 
 let didWarnValDefaultVal = false;
@@ -100,7 +100,7 @@ export function initWrapperState(element: Element, props: Object) {
           defaultValue == null,
           'If you supply `defaultValue` on a <textarea>, do not pass children.',
         );
-        if (isArray(children)) {
+        if (Array.isArray(children)) {
           invariant(
             children.length <= 1,
             '<textarea> can only have at most one child.',

packages/react-dom/src/server/ReactDOMServerFormatConfig.js

@@ -46,7 +46,8 @@ import hyphenateStyleName from '../shared/hyphenateStyleName';
 import invariant from 'shared/invariant';
 import hasOwnProperty from 'shared/hasOwnProperty';
 import sanitizeURL from '../shared/sanitizeURL';
-import isArray from 'shared/isArray';
+
+const isArray = Array.isArray;
 
 // Per response, global state that is not contextual to the rendering subtree.
 export type ResponseState = {

packages/react-dom/src/server/ReactPartialRenderer.js

@@ -14,7 +14,6 @@ import type {ReactProvider, ReactContext} from 'shared/ReactTypes';
 
 import * as React from 'react';
 import invariant from 'shared/invariant';
-import isArray from 'shared/isArray';
 import getComponentNameFromType from 'shared/getComponentNameFromType';
 import {describeUnknownElementTypeFrameInDEV} from 'shared/ReactComponentStackFrame';
 import ReactSharedInternals from 'shared/ReactSharedInternals';
@@ -1439,7 +1438,7 @@ class ReactDOMServerRenderer {
             defaultValue == null,
             'If you supply `defaultValue` on a <textarea>, do not pass children.',
           );
-          if (isArray(textareaChildren)) {
+          if (Array.isArray(textareaChildren)) {
             invariant(
               textareaChildren.length <= 1,
               '<textarea> can only have at most one child.',
@@ -1468,14 +1467,14 @@ class ReactDOMServerRenderer {
           if (props[propName] == null) {
             continue;
           }
-          const propNameIsArray = isArray(props[propName]);
-          if (props.multiple && !propNameIsArray) {
+          const isArray = Array.isArray(props[propName]);
+          if (props.multiple && !isArray) {
             console.error(
               'The `%s` prop supplied to <select> must be an array if ' +
                 '`multiple` is true.',
               propName,
             );
-          } else if (!props.multiple && propNameIsArray) {
+          } else if (!props.multiple && isArray) {
             console.error(
               'The `%s` prop supplied to <select> must be a scalar ' +
                 'value if `multiple` is false.',
@@ -1516,7 +1515,7 @@ class ReactDOMServerRenderer {
           value = optionChildren;
         }
         selected = false;
-        if (isArray(selectValue)) {
+        if (Array.isArray(selectValue)) {
           // multiple
           for (let j = 0; j < selectValue.length; j++) {
             if ('' + selectValue[j] === value) {

packages/react-dom/src/test-utils/ReactTestUtils.js

@@ -24,7 +24,6 @@ import {
   rethrowCaughtError,
   invokeGuardedCallbackAndCatchFirstError,
 } from 'shared/ReactErrorUtils';
-import isArray from 'shared/isArray';
 
 // Keep in sync with ReactDOM.js, and ReactTestUtilsAct.js:
 const EventInternals =
@@ -98,7 +97,7 @@ function validateClassInstance(inst, methodName) {
   }
   let received;
   const stringified = '' + inst;
-  if (isArray(inst)) {
+  if (Array.isArray(inst)) {
     received = 'an array';
   } else if (inst && inst.nodeType === ELEMENT_NODE && inst.tagName) {
     received = 'a DOM node';
@@ -198,7 +197,7 @@ function scryRenderedDOMComponentsWithClass(root, classNames) {
       }
       const classList = className.split(/\s+/);
 
-      if (!isArray(classNames)) {
+      if (!Array.isArray(classNames)) {
         invariant(
           classNames !== undefined,
           'TestUtils.scryRenderedDOMComponentsWithClass expects a ' +
@@ -366,7 +365,7 @@ function executeDispatch(event, listener, inst) {
 function executeDispatchesInOrder(event) {
   const dispatchListeners = event._dispatchListeners;
   const dispatchInstances = event._dispatchInstances;
-  if (isArray(dispatchListeners)) {
+  if (Array.isArray(dispatchListeners)) {
     for (let i = 0; i < dispatchListeners.length; i++) {
       if (event.isPropagationStopped()) {
         break;

packages/react-native-renderer/src/ReactNativeAttributePayload.js

@@ -12,7 +12,6 @@ import {
   deepDiffer,
   flattenStyle,
 } from 'react-native/Libraries/ReactPrivate/ReactNativePrivateInterface';
-import isArray from 'shared/isArray';
 
 import type {AttributeConfiguration} from './ReactNativeTypes';
 
@@ -52,7 +51,7 @@ function restoreDeletedValuesInNestedArray(
   node: NestedNode,
   validAttributes: AttributeConfiguration,
 ) {
-  if (isArray(node)) {
+  if (Array.isArray(node)) {
     let i = node.length;
     while (i-- && removedKeyCount > 0) {
       restoreDeletedValuesInNestedArray(
@@ -164,12 +163,12 @@ function diffNestedProperty(
     return updatePayload;
   }
 
-  if (!isArray(prevProp) && !isArray(nextProp)) {
+  if (!Array.isArray(prevProp) && !Array.isArray(nextProp)) {
     // Both are leaves, we can diff the leaves.
     return diffProperties(updatePayload, prevProp, nextProp, validAttributes);
   }
 
-  if (isArray(prevProp) && isArray(nextProp)) {
+  if (Array.isArray(prevProp) && Array.isArray(nextProp)) {
     // Both are arrays, we can diff the arrays.
     return diffNestedArrayProperty(
       updatePayload,
@@ -179,7 +178,7 @@ function diffNestedProperty(
     );
   }
 
-  if (isArray(prevProp)) {
+  if (Array.isArray(prevProp)) {
     return diffProperties(
       updatePayload,
       // $FlowFixMe - We know that this is always an object when the input is.
@@ -213,7 +212,7 @@ function addNestedProperty(
     return updatePayload;
   }
 
-  if (!isArray(nextProp)) {
+  if (!Array.isArray(nextProp)) {
     // Add each property of the leaf.
     return addProperties(updatePayload, nextProp, validAttributes);
   }
@@ -243,7 +242,7 @@ function clearNestedProperty(
     return updatePayload;
   }
 
-  if (!isArray(prevProp)) {
+  if (!Array.isArray(prevProp)) {
     // Add each property of the leaf.
     return clearProperties(updatePayload, prevProp, validAttributes);
   }